Skip to content

Commit

Permalink
samba-tool drs showrepl tests: improve debugging for mystery error
Browse files Browse the repository at this point in the history
Under some circumstances the samba-tool command is failing with no
stdout output at all, leaving few clues in the logs.

Signed-off-by: Douglas Bagnall <[email protected]>
Reviewed-by: Garming Sam <[email protected]>

Autobuild-User(master): Douglas Bagnall <[email protected]>
Autobuild-Date(master): Fri Aug 10 09:27:03 CEST 2018 on sn-devel-144
  • Loading branch information
douglasbagnall committed Aug 10, 2018
1 parent 1a86733 commit 7528749
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion source4/torture/drs/python/samba_tool_drs_showrepl.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,13 @@ def test_samba_tool_showrepl_summary_forced_failure(self):

except samba.tests.BlackboxProcessError as e:
print("Good, failed as expected after %d rounds: %r" % (i, e.cmd))
self.assertIn('There are failing connections', e.stdout)
self.assertIn('There are failing connections', e.stdout,
msg=('stdout: %r\nstderr: %r\nretcode: %s'
'\nmessage: %r\ncmd: %r') % (e.stdout,
e.stderr,
e.returncode,
e.msg,
e.cmd))
self.assertRegexpMatches(
e.stdout,
r'result 845[67] '
Expand Down

0 comments on commit 7528749

Please sign in to comment.