fix(FEC-9420): PIP button is showed but not working (kaltura#414)

dinoforcered · Nov 7, 2019 · d8be9b4 · d8be9b4
1 parent 14dc625
commit d8be9b4
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/engines/html5/html5.js b/src/engines/html5/html5.js
@@ -543,10 +543,14 @@ export default class Html5 extends FakeEventTarget implements IEngine {
    * @return {boolean} if the engine is in picture in picture mode or not
    */
   isPictureInPictureSupported(): boolean {
-    return (
-      !!document.pictureInPictureEnabled ||
-      (typeof this._el.webkitSupportsPresentationMode === 'function' && this._el.webkitSupportsPresentationMode('picture-in-picture'))
-    );
+    // due to a bug in shaka pip_webkit which sets pictureInPictureEnabled to true in unsupported devices like iphones we will
+    // first rely on the response of webkitSupportsPresentationMode (if exists) and only if not on the pictureInPictureEnabled property
+    if (typeof this._el.webkitSupportsPresentationMode === 'function') {
+      return this._el.webkitSupportsPresentationMode('picture-in-picture');
+    } else {
+      // $FlowFixMe
+      return !!document.pictureInPictureEnabled;
+    }
   }
 
   /**