Skip to content

Commit

Permalink
[WATCHDOG] wdt_pci: fix printk and variable type
Browse files Browse the repository at this point in the history
Fix printk format warning:
drivers/watchdog/wdt_pci.c:652: warning: format '%04x' expects type 'unsigned int', but argument 2 has type 'resource_size_t'

and then use resource_size_t for the "io" variable as well
so that it won't be truncated.

Signed-off-by: Randy Dunlap <[email protected]>
Signed-off-by: Wim Van Sebroeck <[email protected]>
  • Loading branch information
rddunlap authored and Wim Van Sebroeck committed Sep 18, 2009
1 parent 119d3e5 commit d1833c2
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/watchdog/wdt_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ static unsigned long open_lock;
static DEFINE_SPINLOCK(wdtpci_lock);
static char expect_close;

static int io;
static resource_size_t io;
static int irq;

/* Default timeout */
Expand Down Expand Up @@ -648,8 +648,8 @@ static int __devinit wdtpci_init_one(struct pci_dev *dev,
}

if (pci_request_region(dev, 2, "wdt_pci")) {
printk(KERN_ERR PFX "I/O address 0x%04x already in use\n",
pci_resource_start(dev, 2));
printk(KERN_ERR PFX "I/O address 0x%llx already in use\n",
(unsigned long long)pci_resource_start(dev, 2));
goto out_pci;
}

Expand All @@ -663,8 +663,8 @@ static int __devinit wdtpci_init_one(struct pci_dev *dev,
}

printk(KERN_INFO
"PCI-WDT500/501 (PCI-WDG-CSM) driver 0.10 at 0x%04x (Interrupt %d)\n",
io, irq);
"PCI-WDT500/501 (PCI-WDG-CSM) driver 0.10 at 0x%llx (Interrupt %d)\n",
(unsigned long long)io, irq);

/* Check that the heartbeat value is within its range;
if not reset to the default */
Expand Down

0 comments on commit d1833c2

Please sign in to comment.