Merge pull request #52 from divyenduz/fix_tests

fix(tests): after jsdoc refactor
divyenduz · Jun 13, 2024 · cfe1bb3 · cfe1bb3
2 parents 3c47118 + e1dcac7
commit cfe1bb3
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 23 deletions.
diff --git a/bun.lockb b/bun.lockb
diff --git a/src/impl/PLV8ifyCLI.test.ts b/src/impl/PLV8ifyCLI.test.ts
@@ -9,9 +9,12 @@ describe('PLV8ifyCLI tests', () => {
     const sql = plv8ify.getPLV8SQLFunction({
       fn: {
         name: 'test',
+        isExported: true,
         parameters: [],
         comments: [],
-      } as TSFunction,
+        returnType: 'void',
+        jsdocTags: []
+      },
       scopePrefix: 'plv8ify_',
       mode: 'inline',
       defaultVolatility: 'IMMUTABLE',
@@ -22,14 +25,17 @@ describe('PLV8ifyCLI tests', () => {
     expect(sql).toMatchSnapshot()
   })
 
-  it('getSQLFunction with delimiter', async () => {
+  it('getSQLFunction with custom delimiter', async () => {
     const plv8ify = new PLV8ifyCLI()
     const sql = plv8ify.getPLV8SQLFunction({
       fn: {
         name: 'test',
+        isExported: true,
         parameters: [],
         comments: [],
-      } as TSFunction,
+        returnType: 'void',
+        jsdocTags: [],
+      },
       scopePrefix: 'plv8ify_',
       mode: 'inline',
       defaultVolatility: 'IMMUTABLE',
@@ -46,12 +52,15 @@ describe('PLV8ifyCLI tests', () => {
     const sql = plv8ify.getPLV8SQLFunction({
       fn: {
         name: 'test',
+        isExported: true,
         parameters: [
           { name: 'NEW', type: 'testRow' },
           { name: 'OLD', type: 'testRow' },
         ],
         comments: ['//@plv8ify-trigger'],
-      } as TSFunction,
+        returnType: 'object',
+        jsdocTags: []
+      },
       scopePrefix: 'plv8ify_',
       mode: 'inline',
       defaultVolatility: 'IMMUTABLE',
@@ -78,9 +87,12 @@ function test(NEW, OLD) {
     const sql = plv8ify.getPLV8SQLFunction({
       fn: {
         name: 'test',
+        isExported: true,
         parameters: [],
         comments: ['//@plv8ify-schema-name testschema'],
-      } as TSFunction,
+        returnType: 'string',
+        jsdocTags: []
+      },
       scopePrefix: 'plv8ify_',
       mode: 'inline',
       defaultVolatility: 'IMMUTABLE',
@@ -102,9 +114,12 @@ function test() {
     const sql = plv8ify.getPLV8SQLFunction({
       fn: {
         name: 'test',
+        isExported: true,
         parameters: [{ name: 'test', type: 'test_type[]' }],
         comments: [],
-      } as TSFunction,
+        returnType: 'object',
+        jsdocTags: []
+      },
       scopePrefix: '',
       mode: 'inline',
       defaultVolatility: 'IMMUTABLE',

diff --git a/src/impl/__snapshots__/EsBuild.test.ts.snap b/src/impl/__snapshots__/EsBuild.test.ts.snap
@@ -12,6 +12,8 @@ export {
 "
 `;
 
+exports[`EsBuild tests getBundleJs - bad syntax 1`] = `[BundlerError: esbuild failed]`;
+
 exports[`EsBuild tests getBundleJs - newline template 1`] = `
 "// src/test-fixtures/newline-template.fixture.ts
 function sayHello() {
@@ -36,17 +38,3 @@ export {
 };
 "
 `;
-
-exports[`EsBuild tests getBundleJs - newline string 2`] = `
-"// src/test-fixtures/newline-string.fixture.ts
-function sayHello() {
-  const greetString = "hello\nworld";
-  return greetString;
-}
-export {
-  sayHello
-};
-"
-`;
-
-exports[`EsBuild tests getBundleJs - bad syntax 1`] = `[BundlerError: esbuild failed]`;
diff --git a/src/impl/__snapshots__/PLV8ifyCLI.test.ts.snap b/src/impl/__snapshots__/PLV8ifyCLI.test.ts.snap
@@ -9,7 +9,7 @@ return test()
 $plv8ify$ LANGUAGE plv8 IMMUTABLE STRICT;"
 `;
 
-exports[`PLV8ifyCLI tests getSQLFunction with delimiter 1`] = `
+exports[`PLV8ifyCLI tests getSQLFunction with custom delimiter 1`] = `
 "DROP FUNCTION IF EXISTS plv8ify_test();
 CREATE OR REPLACE FUNCTION plv8ify_test() RETURNS JSONB AS $function$
 console.log('hello')
@@ -18,7 +18,6 @@ return test()
 $function$ LANGUAGE plv8 IMMUTABLE STRICT;"
 `;
 
-
 exports[`PLV8ifyCLI tests getSQLFunction with parameters-trigger 1`] = `
 "DROP FUNCTION IF EXISTS plv8ify_test();
 CREATE OR REPLACE FUNCTION plv8ify_test() RETURNS TRIGGER AS $plv8ify$
@@ -41,7 +40,7 @@ $plv8ify$ LANGUAGE plv8 IMMUTABLE STRICT;"
 
 exports[`PLV8ifyCLI tests getSQLFunction with custom-schema 1`] = `
 "DROP FUNCTION IF EXISTS testschema.plv8ify_test();
-CREATE OR REPLACE FUNCTION testschema.plv8ify_test() RETURNS JSONB AS $plv8ify$
+CREATE OR REPLACE FUNCTION testschema.plv8ify_test() RETURNS text AS $plv8ify$
 
 function test() {
   return "hello";