Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Implement overriding postgres types using a custom type map #45

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Feature: Implement overriding postgres types using a custom type map #45

merged 3 commits into from
Jan 20, 2024

Conversation

mattiarossi
Copy link

@mattiarossi mattiarossi commented Jan 18, 2024 •
edited
Loading

Refs #27
Implements custom type mapping by

  • introducing a new flag (--types-config-file )
  • supporting type overrides/additions by including a config file (default, types.ts in the running dir)
  • allowing types/interfaces to be imported from other files and still match them against the custom map

@divyenduz divyenduz self-requested a review January 20, 2024 15:32
divyenduz
divyenduz approved these changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good, added a comment to remove a console.log. Do you mind also adding the new flag to the docs before we merge this!

src/impl/PLV8ifyCLI.ts Outdated Show resolved Hide resolved
@mattiarossi
Copy link
Author

Do you mind also adding the new flag to the docs before we merge this!

Yes, sorry, the I had it in the first pull request but then I realized it was against the previous version ....

@divyenduz divyenduz merged commit d88fb12 into divyenduz:main Jan 20, 2024
4 checks passed
@divyenduz
Copy link
Owner

Thank you for the contribution 🙌🏼
This is live in 0.0.55

@divyenduz
Copy link
Owner

Btw if you write Fix #27 instead of refs #27, the issue is automatically closed on merge 😁

@mattiarossi mattiarossi deleted the feature/27-custom-pgtypes-fix branch January 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenduz divyenduz divyenduz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattiarossi @divyenduz