ovn-northd: Refactor logic for logical port 'up' state update

No functional change. Make it obvious that we determine the logical port 'up' state by checking for bound chassis, and update the NB DB only when state has not been set yet or current state is different. Signed-off-by: Jakub Sitnicki <[email protected]> Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Mark Michelson <[email protected]> Acked-by: Miguel Angel Ajo <[email protected]>
dkarhi · Nov 28, 2017 · 552ffa3 · 552ffa3
1 parent a9e6958
commit 552ffa3
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
@@ -6205,11 +6205,8 @@ update_logical_port_status(struct northd_context *ctx)
             continue;
         }
 
-        if (sb->chassis && (!nbsp->up || !*nbsp->up)) {
-            bool up = true;
-            nbrec_logical_switch_port_set_up(nbsp, &up, 1);
-        } else if (!sb->chassis && (!nbsp->up || *nbsp->up)) {
-            bool up = false;
+        bool up = sb->chassis ? true : false;
+        if (!nbsp->up || *nbsp->up != up) {
             nbrec_logical_switch_port_set_up(nbsp, &up, 1);
         }
     }