Skip to content

Commit

Permalink
dpif-netlink-rtnl: Use OVS_NOT_REACHED in verify.
Browse files Browse the repository at this point in the history
The vport_type_to_kind() call at the top of dpif_netlink_rtnl_verify()
ensures that these cases can never be hit, so use OVS_NOT_REACHED()
instead of setting the err to EOPNOTSUPP.

Signed-off-by: Joe Stringer <[email protected]>
Acked-by: Greg Rose <[email protected]>
Acked-by: Eric Garver <[email protected]>
  • Loading branch information
joestringer committed May 23, 2017
1 parent caeda34 commit b50fcaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/dpif-netlink-rtnl.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ dpif_netlink_rtnl_verify(const struct netdev_tunnel_config *tnl_cfg,
case OVS_VPORT_TYPE_UNSPEC:
case __OVS_VPORT_TYPE_MAX:
default:
err = EOPNOTSUPP;
OVS_NOT_REACHED();
}

ofpbuf_delete(reply);
Expand Down

0 comments on commit b50fcaa

Please sign in to comment.