socket: protect against __proto__ deletion

dkgaoqi · Dec 18, 2012 · bd37a9a · bd37a9a
1 parent 2fa98fb
commit bd37a9a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/socket.js b/lib/socket.js
@@ -250,13 +250,13 @@ Socket.prototype.ack = function(){
  */
 
 Socket.prototype.onack = function(packet){
-  var ack = this.acks[packet.id];
-  if (ack) {
+  var ack = this.acks[Number(packet.id)];
+  if ('function' == typeof ack) {
     debug('calling ack %s with %j', packet.id, packet.data);
     ack.apply(this, packet.data);
     delete this.acks[packet.id];
   } else {
-    debug('ack %s not found', packet.id);
+    debug('bad ack %s', packet.id);
   }
 };