Skip to content

Commit

Permalink
Update admission_control.md
Browse files Browse the repository at this point in the history
I tested out a Limit Ranger, and it seems like the admission happens *before* Validation. Please correct me if I'm wrong though, I didn't look at the code in detail. In any case, I think it makes sense for admission to happen before validation because code in admission can change containers.

By the way I think it's pretty hard to find flows like this in the code, so it's useful if we add links to code in the design docs (for prospective developers) :)
  • Loading branch information
AnanyaKumar committed Jul 31, 2015
1 parent e7f04f7 commit 4a1dcd9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions admission_control.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ will ensure the following:
1. Incoming request
2. Authenticate user
3. Authorize user
4. If operation=create|update, then validate(object)
5. If operation=create|update|delete, then admission.Admit(requestAttributes)
a. invoke each admission.Interface object in sequence
4. If operation=create|update|delete, then admission.Admit(requestAttributes)
a. invoke each admission.Interface object in sequence
5. If operation=create|update, then validate(object)
6. Object is persisted

If at any step, there is an error, the request is canceled.
Expand Down

0 comments on commit 4a1dcd9

Please sign in to comment.