Fixes for docker configuration when running on macOS (darwin) Mojave #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coac
requested changes
Nov 27, 2018
|
@Coac , could you have a look at the changes I have put in place and tell me if it's okay now ? |
Coac
approved these changes
Nov 27, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially (aka works on my macOS Mojave machine) fixes #14
python-reload's file watcher behaves erratically when run in a docker environment when the host is macOS (darwin) Mojave, I believe it may be a bug either in the docker engine itself or in the darwin kernel when handling//double/slash/posix-n-win32-compatible/paths, as well as differing configuration.This patch is based on having run
docker inspecton the container as launched form thesphinx-previewplugin and as launched from the command line.I have not encountered the problems mentioned in #14 with these patches, however given the erratic nature of the error it is very difficult to test in an automated way.