[fix] Updating parse_human_timedelta typing (apache#8436)

dlnan · Oct 23, 2019 · 786d770 · 786d770
1 parent 08c6b61
commit 786d770
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/superset/common/query_object.py b/superset/common/query_object.py
@@ -78,9 +78,7 @@ def __init__(
         )
         self.is_timeseries = is_timeseries
         self.time_range = time_range
-        self.time_shift = (
-            utils.parse_human_timedelta(time_shift) if time_shift else None
-        )
+        self.time_shift = utils.parse_human_timedelta(time_shift)
         self.groupby = groupby or []
 
         # Temporal solution for backward compatability issue

diff --git a/superset/utils/core.py b/superset/utils/core.py
@@ -291,7 +291,7 @@ def default(self, o):
             return json.JSONEncoder(sort_keys=True).default(self, o)
 
 
-def parse_human_timedelta(s: str) -> timedelta:
+def parse_human_timedelta(s: Optional[str]) -> timedelta:
     """
     Returns ``datetime.datetime`` from natural language time deltas
 

diff --git a/tests/utils_tests.py b/tests/utils_tests.py
@@ -130,6 +130,7 @@ def test_parse_human_timedelta(self, mock_datetime):
         self.assertEqual(parse_human_timedelta("now"), timedelta(0))
         self.assertEqual(parse_human_timedelta("1 year"), timedelta(366))
         self.assertEqual(parse_human_timedelta("-1 year"), timedelta(-365))
+        self.assertEqual(parse_human_timedelta(None), timedelta(0))
 
     @patch("superset.utils.core.datetime")
     def test_parse_past_timedelta(self, mock_datetime):