[CUDA][Kernel] A bunch of int64 kernels for COO and CSR #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermainewang
changed the title
yzh119
approved these changes
Jul 30, 2020
| * \brief Sort the ID vector in ascending order. | ||
| * | ||
| * It performs both sort and arg_sort (returning the sorted index). The sorted index | ||
| * is always in int64. |
There was a problem hiding this comment.
Why the sorted index is always int64, is it designed to be compatible with pytorch?
There was a problem hiding this comment.
I think int64 is the safest since the tensor shape is in int64.
| return ret; | ||
| } | ||
|
|
||
| std::ptrdiff_t operator-(const PairIterator& other) const { |
There was a problem hiding this comment.
Is it used for computing the difference of two iterators? When would this function be called?
There was a problem hiding this comment.
It's part of the random-access iterator interface. I guess some sort algorithms might use this operator.
| IdType* val_data = val.Ptr<IdType>(); | ||
| int64_t* idx_data = idx.Ptr<int64_t>(); | ||
| typedef std::pair<IdType, int64_t> Pair; | ||
| #ifdef PARALLEL_ALGORITHMS |
There was a problem hiding this comment.
@classicsong , when would this flag be activated?
kingmbc
pushed a commit
to kingmbc/dgl
that referenced
this pull request
Aug 2, 2020
* COO sort * COOToCSR * CSR2COO * CSRSort; CSRTranspose * pass all CSR tests * lint * remove int32 conversion * fix tensorflow nn tests * turn on CI * fix * addreess comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New kernels added for int64 CSR/COO on CUDA:
TODO
* Integrate with python and fix bugs.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change