Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vendor dict #245

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Updated vendor dict #245

merged 1 commit into from
Apr 11, 2024

Conversation

treavorj
Copy link
Contributor

@treavorj treavorj commented Apr 9, 2024

Updated vendor dict with input from querying ODVA's website

Short description of change

Updated the vendor dict to from data queryied from ODVA's website. Where conflicts existed, data from ODVA's website took precedence. Where data did not exist on ODVA's website, data in the existing dict was kept.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the docs/CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read tests/README.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

What is the change?

Additional vendors added to the vendor dict

What does it fix/add?

Adds additional missing vendors per ODVA

Test Configuration

No testing performed (only dict values changed)

  • PLC Model
  • PLC Firmware
  • pylogix version
  • python version
  • OS type and version

Updated vendor dict with input from querying ODVA's website
@dmroeder dmroeder merged commit 0ced022 into dmroeder:master Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants