count($test_files) already be checked above : if ($test_cnt)

thus we can use $sum_results instead of the preg_match
do-aki · Nov 25, 2012 · 16efc77 · 16efc77
1 parent 11c946e
commit 16efc77
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/run-tests.php b/run-tests.php
@@ -802,14 +802,12 @@ function save_or_mail_results()
 			fclose($failed_tests_file);
 		}
 
-		if (count($test_files) || count($test_results)) {
-			compute_summary();
-			if ($html_output) {
-				fwrite($html_file, "<hr/>\n" . get_summary(false, true));
-			}
-			echo "=====================================================================";
-			echo get_summary(false, false);
+		compute_summary();
+		if ($html_output) {
+			fwrite($html_file, "<hr/>\n" . get_summary(false, true));
 		}
+		echo "=====================================================================";
+		echo get_summary(false, false);
 
 		if ($html_output) {
 			fclose($html_file);
@@ -821,7 +819,7 @@ function save_or_mail_results()
 
 		junit_save_xml();
 
-		if (getenv('REPORT_EXIT_STATUS') == 1 and preg_match('/ FAILED(?: |$)/', implode(' ', $test_results))) {
+		if (getenv('REPORT_EXIT_STATUS') == 1 and $sum_results['FAILED']) {
 			exit(1);
 		}