[Move] Return error instead of panicking on primitive type event (Mys…

…tenLabs#2610)
dobrotabus · Jun 17, 2022 · d13a50f · d13a50f
1 parent 9c4b188
commit d13a50f
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/crates/sui-framework/src/natives/event.rs b/crates/sui-framework/src/natives/event.rs
@@ -2,8 +2,8 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use crate::EventType;
-use move_binary_format::errors::PartialVMResult;
-use move_core_types::gas_schedule::GasAlgebra;
+use move_binary_format::errors::{PartialVMError, PartialVMResult};
+use move_core_types::{gas_schedule::GasAlgebra, vm_status::StatusCode};
 use move_vm_runtime::native_functions::NativeContext;
 use move_vm_types::{
     gas_schedule::NativeCostIndex,
@@ -33,8 +33,9 @@ pub fn emit(
     match ty {
         Type::Struct(..) | Type::StructInstantiation(..) => (),
         ty => {
-            // TODO: // TODO(https://github.com/MystenLabs/sui/issues/19): enforce this in the ability system
-            panic!("Unsupported event type {:?}--struct expected", ty)
+            // TODO (https://github.com/MystenLabs/sui/issues/19): ideally enforce this in the ability system
+            return Err(PartialVMError::new(StatusCode::DATA_FORMAT_ERROR)
+                .with_message(format!("Unsupported event type {:?} (struct expected)", ty)));
         }
     }