Skip to content

Commit

Permalink
Make PKGBUILD packaging standards compliant.
Browse files Browse the repository at this point in the history
* replace pointless patch with PYTHON=python2
* simplify git describe command
* move pkgver() function lower, so build chroots can make use of it
* align packages in optdepends using spaces
* use double quotation marks only where it's needed
* unify usage of brackets sorrounding variables
* shorten pkgdesc (kudos to Fedora)
* update README
  • Loading branch information
barthalion committed Feb 5, 2014
1 parent 66f47c2 commit 24ae4f0
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 41 deletions.
51 changes: 24 additions & 27 deletions packaging/arch/PKGBUILD
Original file line number Diff line number Diff line change
@@ -1,43 +1,40 @@
#Maintainer: Michel Blanc <[email protected]>
# Maintainer: Michel Blanc <[email protected]>

pkgname=ansible-git
pkgver=1.1.912.gedb6a68
pkgver(){
cd "$srcdir/$pkgname"
git describe --tags --long | sed 's/^v//;s/-/./g'
}
pkgver=1.1.3403.g5cd97e8
pkgrel=1
pkgdesc="A radically simple IT automation"
pkgdesc='A radically simple IT automation'
arch=('any')
url="http://www.ansible.com"
url='http://www.ansible.com'
license=('GPL3')
depends=('python2' 'python2-paramiko' 'python2-jinja' 'python2-yaml')
makedepends=('git' 'asciidoc' 'fakeroot')
optdepends=('python2-pyzmq: needed for fireball mode'
'python2-pyasn1: needed for fireball mode'
'python2-crypto: needed for fireball mode'
'python2-keyczar: needed for fireball mode')
'python2-pyasn1: needed for fireball mode'
'python2-crypto: needed for fireball mode'
'python2-keyczar: needed for fireball mode')
conflicts=('ansible')
provides=('ansible')
source=("$pkgname::git://github.com/ansible/ansible.git"
"python-binary.diff")
md5sums=("SKIP" "ab81876d8d4c86c27d137e3d86c25a3a")
backup=('etc/ansible/ansible.cfg')
source=($pkgname::git://github.com/ansible/ansible.git)
md5sums=('SKIP')

prepare(){
cd "$srcdir/$pkgname"
patch -p1 -i "$srcdir/python-binary.diff"
pkgver() {
cd $pkgname
git describe --long | sed 's/^v//;s/-/./g'
}

build() {
cd "$srcdir/$pkgname"
make
cd $pkgname
make PYTHON=python2
}

package() {
cd "$srcdir/$pkgname"
cd $pkgname

mkdir -p "${pkgdir}/usr/share/ansible"
cp -dpr --no-preserve=ownership ./library/* "${pkgdir}/usr/share/ansible/"
cp -dpr --no-preserve=ownership ./examples "${pkgdir}/usr/share/ansible"
mkdir -p "$pkgdir/usr/share/ansible"
cp -dpr --no-preserve=ownership ./library/* "$pkgdir/usr/share/ansible/"
cp -dpr --no-preserve=ownership ./examples "$pkgdir/usr/share/ansible"

python2 setup.py install -O1 --root="$pkgdir"

Expand All @@ -49,8 +46,8 @@ package() {
install -D CONTRIBUTING.md "$pkgdir/usr/share/doc/ansible/CONTRIBUTING.md"
install -D RELEASES.txt "$pkgdir/usr/share/doc/ansible/RELEASES.txt"

install -D docs/man/man1/ansible.1 "${pkgdir}/usr/share/man/man1/ansible.1"
install -D docs/man/man1/ansible-playbook.1 "${pkgdir}/usr/share/man/man1/ansible-playbook.1"
install -D docs/man/man1/ansible-pull.1 "${pkgdir}/usr/share/man/man1/ansible-pull.1"
install -D docs/man/man1/ansible-doc.1 "${pkgdir}/usr/share/man/man1/ansible-doc.1"
install -D docs/man/man1/ansible.1 "$pkgdir/usr/share/man/man1/ansible.1"
install -D docs/man/man1/ansible-playbook.1 "$pkgdir/usr/share/man/man1/ansible-playbook.1"
install -D docs/man/man1/ansible-pull.1 "$pkgdir/usr/share/man/man1/ansible-pull.1"
install -D docs/man/man1/ansible-doc.1 "$pkgdir/usr/share/man/man1/ansible-doc.1"
}
6 changes: 3 additions & 3 deletions packaging/arch/README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
Arch Packaging Files
--------------------

The PKGBUILD and patch in this directory are here for reference.
You should use AUR to install [ansible-git][1], using `yaourt` for instance :
The PKGBUILD in this directory is here for reference.
You should use AUR to install [ansible-git][1], using `yaourt` for instance:

yaourt -S ansible-git

You can also find a stable AUR package for the stable version of [ansible][2].
You can also use a AUR package for the stable version of [ansible][2].

[1]: https://aur.archlinux.org/packages/ansible-git/
[2]: https://aur.archlinux.org/packages/ansible/
Expand Down
11 changes: 0 additions & 11 deletions packaging/arch/python-binary.diff

This file was deleted.

0 comments on commit 24ae4f0

Please sign in to comment.