Remove alpine isnan/isinf workaround #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was fixed with ruby/ruby@74f94b3 https://bugs.ruby-lang.org/issues/15595 This was shipped with Ruby 2.7, so it should be unnecessary now
|
There's this: It looks like ruby has changed things to the point where these don't even do anything anymore. I don't find Edit: Ah, here it is. ruby/ruby@04be8e8. So yes, not needed anymore. Was added in 3.1 which conveniently is the lowest version being build here. |
LaurentGoderre
approved these changes
Dec 5, 2024
yosifkit
approved these changes
Dec 5, 2024
Merged
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 6, 2024
Changes: - docker-library/ruby@1e6be83: Merge pull request docker-library/ruby#486 from Earlopain/alpine-3.21 - docker-library/ruby@c792563: https://alpinelinux.org/posts/Alpine-3.21.0-released.html - docker-library/ruby@275c71d: Merge pull request docker-library/ruby#485 from Earlopain/alpine-isnan-isinf-workaround - docker-library/ruby@bbd386f: Remove alpine isnan/isinf workaround - docker-library/ruby@cf905a6: Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was fixed with ruby/ruby@74f94b3
https://bugs.ruby-lang.org/issues/15595
This was shipped with Ruby 2.7, so it should be unnecessary now. I'll check the build output if that is indeed the case.