Leverage generic persistence event classes

doctrine · May 1, 2022 · bf2ca44 · bf2ca44
1 parent 6d5fc5b
commit bf2ca44
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 23 deletions.
diff --git a/lib/Doctrine/ODM/MongoDB/Event/LifecycleEventArgs.php b/lib/Doctrine/ODM/MongoDB/Event/LifecycleEventArgs.php
@@ -7,11 +7,11 @@
 use Doctrine\ODM\MongoDB\DocumentManager;
 use Doctrine\Persistence\Event\LifecycleEventArgs as BaseLifecycleEventArgs;
 
-use function assert;
-
 /**
  * Lifecycle Events are triggered by the UnitOfWork during lifecycle transitions
  * of documents.
+ *
+ * @template-extends BaseLifecycleEventArgs<DocumentManager>
  */
 class LifecycleEventArgs extends BaseLifecycleEventArgs
 {
@@ -22,9 +22,6 @@ public function getDocument(): object
 
     public function getDocumentManager(): DocumentManager
     {
-        $dm = $this->getObjectManager();
-        assert($dm instanceof DocumentManager);
-
-        return $dm;
+        return $this->getObjectManager();
     }
 }
diff --git a/lib/Doctrine/ODM/MongoDB/Event/LoadClassMetadataEventArgs.php b/lib/Doctrine/ODM/MongoDB/Event/LoadClassMetadataEventArgs.php
@@ -5,20 +5,18 @@
 namespace Doctrine\ODM\MongoDB\Event;
 
 use Doctrine\ODM\MongoDB\DocumentManager;
+use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
 use Doctrine\Persistence\Event\LoadClassMetadataEventArgs as BaseLoadClassMetadataEventArgs;
 
-use function assert;
-
 /**
  * Class that holds event arguments for a loadMetadata event.
+ *
+ * @template-extends BaseLoadClassMetadataEventArgs<ClassMetadata<object>, DocumentManager>
  */
 final class LoadClassMetadataEventArgs extends BaseLoadClassMetadataEventArgs
 {
     public function getDocumentManager(): DocumentManager
     {
-        $dm = $this->getObjectManager();
-        assert($dm instanceof DocumentManager);
-
-        return $dm;
+        return $this->getObjectManager();
     }
 }
diff --git a/lib/Doctrine/ODM/MongoDB/Event/ManagerEventArgs.php b/lib/Doctrine/ODM/MongoDB/Event/ManagerEventArgs.php
@@ -7,18 +7,15 @@
 use Doctrine\ODM\MongoDB\DocumentManager;
 use Doctrine\Persistence\Event\ManagerEventArgs as BaseManagerEventArgs;
 
-use function assert;
-
 /**
  * Provides event arguments for the flush events.
+ *
+ * @template-extends BaseManagerEventArgs<DocumentManager>
  */
 class ManagerEventArgs extends BaseManagerEventArgs
 {
     public function getDocumentManager(): DocumentManager
     {
-        $dm = $this->getObjectManager();
-        assert($dm instanceof DocumentManager);
-
-        return $dm;
+        return $this->getObjectManager();
     }
 }
diff --git a/lib/Doctrine/ODM/MongoDB/Event/OnClearEventArgs.php b/lib/Doctrine/ODM/MongoDB/Event/OnClearEventArgs.php
@@ -7,13 +7,14 @@
 use Doctrine\ODM\MongoDB\DocumentManager;
 use Doctrine\Persistence\Event\OnClearEventArgs as BaseOnClearEventArgs;
 
-use function assert;
 use function func_num_args;
 use function method_exists;
 use function trigger_deprecation;
 
 /**
  * Provides event arguments for the onClear event.
+ *
+ * @template-extends BaseOnClearEventArgs<DocumentManager>
  */
 final class OnClearEventArgs extends BaseOnClearEventArgs
 {
@@ -50,10 +51,7 @@ public function __construct($objectManager, $entityClass = null)
 
     public function getDocumentManager(): DocumentManager
     {
-        $dm = $this->getObjectManager();
-        assert($dm instanceof DocumentManager);
-
-        return $dm;
+        return $this->getObjectManager();
     }
 
     /**