Fix documentation for uploadFromFile

[rrajkomar]

Q	A
Type	improvement
BC Break	no
Fixed issues	#2283

Summary

Fixed argument order
Fixed example with Metadata object used instead of UpdloadOptions containing the metadata

[SenseException]

That's a good catch.

Please change the base branch to 2.2.x, because as far as I understood @malarzm. 2.2.x is still the minimum supported branch despite not being the default branch.

There also a call of $repository->uploadFromFile() on line 239 you've missed.

[malarzm]

@SenseException I'm going to change the default branch now, forgot to do that yesterday :)

@rrajkomar I tried to change the target branch for you but it produced additional commits. You'll need to rebase your work atop 2.2.x

[rrajkomar]

@malarzm. This should do it.

[SenseException]

Please also fix the other $repository->uploadFromFile('image.jpg', parts.

[rrajkomar]

@SenseException I think I fixed them all this time. Coudn't find any other concerned reference of the method.

[malarzm]

@SenseException with @alcaeus' approval I'm marking this as good to go.

Thanks @rrajkomar!