Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated driver functionality #2680

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 30, 2024

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

To prepare for an upcoming 2.0 release of the extension, we need to stop using deprecated symbols. In this PR:

  • replace usages of deprecated BSON functions with functionality from MongoDB\BSON\Document
  • replace usages of deprecated ReadPreference::RP_* constants
  • replace usages of deprecated ReadPreference::getMode() method

Additional pull requests will be made as changes happen in the driver.

@alcaeus alcaeus requested a review from GromNaN September 30, 2024 12:43
@alcaeus
Copy link
Member Author

alcaeus commented Sep 30, 2024

Note: the job testing with lowest dependencies was cancelled due to the sharded job failure. I've created #2681 to disable that for the time being and would like to give the "lowest" job a chance to complete successfully to make sure we don't need to further bump the minimum version.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcaeus alcaeus force-pushed the remove-deprecated-stuff branch from 9512c58 to 21fc0e9 Compare October 1, 2024 10:55
@alcaeus alcaeus merged commit db07f53 into doctrine:2.10.x Oct 1, 2024
16 checks passed
@alcaeus alcaeus deleted the remove-deprecated-stuff branch October 1, 2024 11:28
GromNaN pushed a commit to GromNaN/mongodb-odm that referenced this pull request Oct 19, 2024
* Remove usages of deprecated BSON functions

* Remove usages of deprecated read preference functionality

* Update phpstan baseline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants