Tests and fix for MODM-91 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s null, the data should be set to null (instead of being ignored). Ignoring the null value entirely causes problems when generating the changeset (causes false positives because of the null field).
Because embedded documents are properly given null values, the persistence needs to be smart to treat an entirely empty embedded document as a "new" value (instead of as an update). Without this change, test MODM48Test throws the following exception "MongoCursorException: can't append to array using string field name [val]".
|
I see the problem and that this effectively fixes it, so thank you for the fix and the test case. |
|
Thanks I merged your test and it passes now after the recent refactoring! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys-
Ticket here: http://www.doctrine-project.org/jira/browse/MODM-91
Let me know if you have any comments/questions - all of the tests are passing, but this is a fairly fundamental change to how the internal data for embedded documents is stored.
Thanks!