plan/validator: return an error when alter auto_incerment (pingcap#3041…

…) (pingcap#3072)

plan/planbuilder.go

@@ -36,12 +36,14 @@ var (
 	ErrUnknownColumn        = terror.ClassOptimizerPlan.New(CodeUnknownColumn, "Unknown column '%s' in '%s'")
 	ErrWrongArguments       = terror.ClassOptimizerPlan.New(CodeWrongArguments, "Incorrect arguments to EXECUTE")
 	ErrAmbiguous            = terror.ClassOptimizerPlan.New(CodeAmbiguous, "Column '%s' in field list is ambiguous")
+	ErrAlterAutoID          = terror.ClassAutoid.New(CodeAlterAutoID, "No support for setting auto_increment using alter_table")
 )
 
 // Error codes.
 const (
 	CodeUnsupportedType terror.ErrCode = 1
 	SystemInternalError terror.ErrCode = 2
+	CodeAlterAutoID     terror.ErrCode = 3
 	CodeAmbiguous       terror.ErrCode = 1052
 	CodeUnknownColumn   terror.ErrCode = 1054
 	CodeWrongArguments  terror.ErrCode = 1210

plan/validator.go

@@ -271,6 +271,13 @@ func (v *validator) checkAlterTableGrammar(stmt *ast.AlterTableStmt) {
 			default:
 				// Nothing to do now.
 			}
+		case ast.AlterTableOption:
+			for _, opt := range spec.Options {
+				if opt.Tp == ast.TableOptionAutoIncrement {
+					v.err = ErrAlterAutoID
+					return
+				}
+			}
 		default:
 			// Nothing to do now.
 		}

plan/validator_test.go

@@ -71,6 +71,10 @@ func (s *testValidatorSuite) TestValidator(c *C) {
 			errors.New("[schema:1068]Multiple primary key defined")},
 		{"create table t(c1 int not null, c2 int not null, primary key(c1), primary key(c2))", true,
 			errors.New("[schema:1068]Multiple primary key defined")},
+		{"alter table t auto_increment=1", true, errors.New("[autoid:3]No support for setting auto_increment using alter_table")},
+		{"alter table t add column c int auto_increment key, auto_increment=10", true,
+			errors.New("[autoid:3]No support for setting auto_increment using alter_table")},
+		{"alter table t add column c int auto_increment key", true, nil},
 	}
 
 	store, err := tidb.NewStore(tidb.EngineGoLevelDBMemory)