plan: open some test. (pingcap#5811)

doerjiayi · Feb 7, 2018 · 901e898 · 901e898
1 parent 5be134e
commit 901e898
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/plan/logical_plan_test.go b/plan/logical_plan_test.go
@@ -1077,15 +1077,14 @@ func (s *testPlanSuite) TestValidate(c *C) {
 			sql: "insert into t set a = 1, b = values(a) + 1",
 			err: nil,
 		},
-		// TODO: Fix Error Code.
-		//{
-		//	sql: "select a, b, c from t order by 0",
-		//	err: ErrUnknownColumn,
-		//},
-		//{
-		//	sql: "select a, b, c from t order by 4",
-		//	err: ErrUnknownColumn,
-		//},
+		{
+			sql: "select a, b, c from t order by 0",
+			err: ErrUnknownColumn,
+		},
+		{
+			sql: "select a, b, c from t order by 4",
+			err: ErrUnknownColumn,
+		},
 		{
 			sql: "select a as c1, b as c1 from t order by c1",
 			err: ErrAmbiguous,
@@ -1094,10 +1093,10 @@ func (s *testPlanSuite) TestValidate(c *C) {
 			sql: "(select a as b, b from t) union (select a, b from t) order by b",
 			err: ErrAmbiguous,
 		},
-		//{
-		//	sql: "(select a as b, b from t) union (select a, b from t) order by a",
-		//	err: ErrUnknownColumn,
-		//},
+		{
+			sql: "(select a as b, b from t) union (select a, b from t) order by a",
+			err: ErrUnknownColumn,
+		},
 		{
 			sql: "select * from t t1 use index(e)",
 			err: ErrKeyDoesNotExist,