Skip to content

Commit

Permalink
sessionctx/binloginfo: make TestMaxRecvSize more stable (pingcap#6771)
Browse files Browse the repository at this point in the history
TestIgnoreError may clean up fail, rename it to TestZIgnoreError so
even it fails, it doesn't not affect TestMaxRecvSize.
  • Loading branch information
tiancaiamao authored Jun 6, 2018
1 parent 96a5109 commit ac1be1d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion sessionctx/binloginfo/binloginfo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,9 @@ func mutationRowsToRows(c *C, mutationRows [][]byte, columnValueOffsets ...int)
return rows
}

func (s *testBinlogSuite) TestIgnoreError(c *C) {
// Sometimes this test doesn't clean up fail, let the function name begin with 'Z'
// so it runs last and would not disrupt other tests.
func (s *testBinlogSuite) TestZIgnoreError(c *C) {
tk := testkit.NewTestKit(c, s.store)
tk.MustExec("use test")
tk.Se.GetSessionVars().BinlogClient = s.client
Expand Down

0 comments on commit ac1be1d

Please sign in to comment.