update: Fix check URLs for macos-universal returning 404 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
I'm not very familiar with this repo, but in the interests of pushing this along I'll review it anyway.
The changes make sense, and after grepping through the code for case-insensitive "mac" I didn't see any other places in www that need to be modified to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex to extract the platform in
/update/checkuses\w, which does not match dashes. This causes allmacos-universalupdate checks to return 404 Not Found. So, I replaced\wwith something equivalent that also matches dashes.In addition, I added
macos-universalto the supported platforms check.This PR is completely untested, because I have no idea how to spin up an instance of this. I'm pretty sure the changes are correct, though...