downloads: Handle duplicate version names #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've deployed your PR in our testing environment at It looks like an error is being thrown. Note that we're using an ancient version of Django at the moment. |
If there is more than one version on a branch with a given shortrev, get_object_or_404 would raise a MultipleObjectsReturned exception. It is better just to pick one. Since these duplicate versions come from force pushes, the oldest should be the original and thus the most useful one to pick.
This information is included for hash-based lookups as well as branch+shortrev-based since it's relevant in either case.
Amphitryon0
force-pushed
the
duplicate-versions
branch
from
bf923e3 to
288ec19
Compare
|
The version is fine; I was just using it wrong. I've hopefully fixed that as well as an error when getting by name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are sometimes multiple versions with the same branch and name, such as 3.5-154 (00d303e) and 3.5-154 (2844708). The current behavior is to assume that never happens, so you get a 500 response if you look them up by name. This change defaults to the oldest version in that case and informs the visitor of the ambiguity.
This still needs to be tested; I don't know how to do so.