Review comments

docs/source/changelog.rst

@@ -7,8 +7,8 @@ release, see :doc:`upgrade-notes`.
 Unreleased
 ==========
 
-* Fix CORDA-1229. Setter based serialization was broken with generic types when the property was stored
-  as the interface type, List for example. 
+* Fix CORDA-1229. Setter-based serialization was broken with generic types when the property was stored
+  as the raw type, List for example.
 
 * java.security.cert.CRLReason added to the default Whitelist.
 

node-api/src/main/kotlin/net/corda/nodeapi/internal/serialization/amqp/SerializationHelper.kt

@@ -314,7 +314,7 @@ fun propertiesForSerializationFromSetters(
                         "${property.value.field?.genericType!!}")
             }
 
-            // make sure the getter returns the same type (within inheritance bounds) the setter accepts
+            // Make sure the getter returns the same type (within inheritance bounds) the setter accepts.
             if (!(TypeToken.of (getter.genericReturnType).isSupertypeOf(setterType))) {
                 throw NotSerializableException("Defined setter for parameter ${property.value.field?.name} " +
                         "takes parameter of type $setterType yet the defined getter returns a value of type " +

node-api/src/test/java/net/corda/nodeapi/internal/serialization/amqp/SetterConstructorTests.java

@@ -345,8 +345,8 @@ public void intList() throws NotSerializableException {
                 evolutionSerialiserGetter,
                 fingerPrinter);
 
-        // if we've got super / sub types on the setter vs the unerlaying type the wrong way around this will
-        // explode
+        // if we've got super / sub types on the setter vs the underlying type the wrong way around this will
+        // explode. See CORDA-1229 (https://r3-cev.atlassian.net/browse/CORDA-1229)
         new SerializationOutput(factory1).serialize(cil);
     }
 }