Skip to content

Commit

Permalink
Rename flavor API and CRDs to instancetype
Browse files Browse the repository at this point in the history 
The term flavor was taken from the OpenStack Nova project and while it
does encapsulate parts of what the API is trying to achieve within
KubeVirt it isn't entirely obvious to non-OpenStack users. Before the
API and associated CRDs move out of alphav1 this change replaces the use
of Flavor with the more commonly used term of instance type [1].

The use of the term flavor remains within the vm-preset code as this
predates the flavor API and CRD implementation being renamed here. As
highlighted elsewhere this needs to be deprecated and removed in the
future.

RBAC permissions for the Flavor API are retained by the virt-operator in
order for updates from v0.54 to current HEAD and eventually v0.55 to
continue to work. These permissions should then be dropped by the v0.56
release.

[1] https://aws.amazon.com/ec2/instance-types/

Signed-off-by: Lee Yarwood <[email protected]>
  • Loading branch information
@lyarwood
lyarwood committed Jul 11, 2022
1 parent fc9301d commit 4eb29b8
Show file tree
Hide file tree
Showing 111 changed files with 2,924 additions and 2,876 deletions.
6 changes: 3 additions & 3 deletions api/api-rule-violations-known.list
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineSpec
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,Conditions
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,StateChangeRequests
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,VolumeSnapshotStatuses
API rule violation: list_type_missing,kubevirt.io/api/flavor/v1alpha1,VirtualMachineClusterFlavorList,Items
API rule violation: list_type_missing,kubevirt.io/api/flavor/v1alpha1,VirtualMachineFlavorList,Items
API rule violation: list_type_missing,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineClusterInstancetypeList,Items
API rule violation: list_type_missing,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineInstancetypeList,Items
API rule violation: list_type_missing,kubevirt.io/api/pool/v1alpha1,VirtualMachinePoolList,Items
API rule violation: list_type_missing,kubevirt.io/api/snapshot/v1alpha1,VirtualMachineRestoreList,Items
API rule violation: list_type_missing,kubevirt.io/api/snapshot/v1alpha1,VirtualMachineRestoreStatus,Conditions
Expand Down Expand Up @@ -288,7 +288,7 @@ API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceMi
API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceNetworkInterface,IP
API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceNetworkInterface,IPs
API rule violation: names_match,kubevirt.io/api/core/v1,WatchdogDevice,I6300ESB
API rule violation: names_match,kubevirt.io/api/flavor/v1alpha1,VirtualMachineFlavorSpec,GPUs
API rule violation: names_match,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineInstancetypeSpec,GPUs
API rule violation: names_match,kubevirt.io/api/snapshot/v1alpha1,VolumeRestore,PersistentVolumeClaimName
API rule violation: names_match,kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1,CDISpec,Workloads
API rule violation: names_match,kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1,DataVolumeSourceImageIO,DiskID
Expand Down
6 changes: 3 additions & 3 deletions api/api-rule-violations.list
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineSpec
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,Conditions
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,StateChangeRequests
API rule violation: list_type_missing,kubevirt.io/api/core/v1,VirtualMachineStatus,VolumeSnapshotStatuses
API rule violation: list_type_missing,kubevirt.io/api/flavor/v1alpha1,VirtualMachineClusterFlavorList,Items
API rule violation: list_type_missing,kubevirt.io/api/flavor/v1alpha1,VirtualMachineFlavorList,Items
API rule violation: list_type_missing,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineClusterInstancetypeList,Items
API rule violation: list_type_missing,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineInstancetypeList,Items
API rule violation: list_type_missing,kubevirt.io/api/pool/v1alpha1,VirtualMachinePoolList,Items
API rule violation: list_type_missing,kubevirt.io/api/snapshot/v1alpha1,VirtualMachineRestoreList,Items
API rule violation: list_type_missing,kubevirt.io/api/snapshot/v1alpha1,VirtualMachineRestoreStatus,Conditions
Expand Down Expand Up @@ -288,7 +288,7 @@ API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceMi
API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceNetworkInterface,IP
API rule violation: names_match,kubevirt.io/api/core/v1,VirtualMachineInstanceNetworkInterface,IPs
API rule violation: names_match,kubevirt.io/api/core/v1,WatchdogDevice,I6300ESB
API rule violation: names_match,kubevirt.io/api/flavor/v1alpha1,VirtualMachineFlavorSpec,GPUs
API rule violation: names_match,kubevirt.io/api/instancetype/v1alpha1,VirtualMachineInstancetypeSpec,GPUs
API rule violation: names_match,kubevirt.io/api/snapshot/v1alpha1,VolumeRestore,PersistentVolumeClaimName
API rule violation: names_match,kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1,CDISpec,Workloads
API rule violation: names_match,kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1,DataVolumeSourceImageIO,DiskID
Expand Down
Loading

0 comments on commit 4eb29b8

Please sign in to comment.