Skip to content

Commit

Permalink
h2h3: fix overriding the 'TE: Trailers' header
Browse files Browse the repository at this point in the history
A 'TE: Trailers' header is explicitly replaced by 'te: trailers'
(lowercase) in Curl_pseudo_headers() when building the list of HTTP/2 or
HTTP/3 headers. However, this is then replaced again by the original
value due to a bug, resulting in the uppercased version being sent. Some
HTTP/2 servers reject the whole HTTP/2 stream when this is the case.

Closes curl#9170
  • Loading branch information
lwthiker authored and bagder committed Jul 18, 2022
1 parent 0484127 commit b9b6148
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lib/h2h3.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@ CURLcode Curl_pseudo_headers(struct Curl_easy *data,
nva[i].valuelen = (end - hdbuf);
}

nva[i].value = hdbuf;
nva[i].valuelen = (end - hdbuf);

++i;
}

Expand Down

0 comments on commit b9b6148

Please sign in to comment.