Confirm restore popup fragment rendering error when system context ID is not 1 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lls where the system context.id is not 1. Add the course contextid to the block renderer in classes/output/block/content.php and in templates/block/content.mustache Update amd/src/app/block/element.js using the data-contextid attribute when rendering the modal fragment instead of assuming the context.id=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with rendering the popup to confirm restore on Moodle installs where the system context.id is not 1.
Add the course contextid to the block renderer in classes/output/block/content.php and in templates/block/content.mustache Update amd/src/app/block/element.js using the data-contextid attribute when rendering the modal fragment instead of assuming the context.id=1