Skip to content

Commit

Permalink
Add missing override annotations.
Browse files Browse the repository at this point in the history
  • Loading branch information
donraab committed Jun 25, 2024
1 parent 6d902d1 commit de8a827
Show file tree
Hide file tree
Showing 26 changed files with 37 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ default String getValueAsString(int rowIndex)
return value == null ? "" : this.FORMATTER.format(value);
}

@Override
default ValueType getType()
{
return ValueType.DATE;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ default String getValueAsString(int rowIndex)
return value == null ? "" : this.FORMATTER.format(value);
}

@Override
default ValueType getType()
{
return ValueType.DATE_TIME;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ default String getValueAsString(int rowIndex)
return value == null ? "" : value.toString();
}

@Override
default ValueType getType()
{
return ValueType.DECIMAL;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public ImmutableDoubleList toDoubleList()
.toImmutable();
}

@Override
public ValueType getType()
{
return ValueType.DOUBLE;
Expand Down Expand Up @@ -65,6 +66,7 @@ public DfColumn mergeWithInto(DfColumn other, DataFrame target)
return mergedCol;
}

@Override
public DfColumn copyTo(DataFrame target)
{
DfDoubleColumn targetCol = (DfDoubleColumn) this.copyColumnSchemaAndEnsureCapacity(target);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public Object getObject(int rowIndex)
return this.getDoubleWithoutNullCheck(rowIndex);
}

@Override
public double getDouble(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down Expand Up @@ -128,6 +129,7 @@ public void addEmptyValue()
this.values.add(Double.NaN);
}

@Override
public void aggregateValueInto(int rowIndex, DfColumn sourceColumn, int sourceRowIndex, AggregateFunction aggregator)
{
aggregator.aggregateValueIntoDouble(this, rowIndex, sourceColumn, sourceRowIndex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public ImmutableFloatList toFloatList()
.toImmutable();
}

@Override
public ValueType getType()
{
return ValueType.FLOAT;
Expand Down Expand Up @@ -65,6 +66,7 @@ public DfColumn mergeWithInto(DfColumn other, DataFrame target)
return mergedCol;
}

@Override
public DfColumn copyTo(DataFrame target)
{
DfFloatColumn targetCol = (DfFloatColumn) this.copyColumnSchemaAndEnsureCapacity(target);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ public Object getObject(int rowIndex)
return this.getFloatWithoutNullCheck(rowIndex);
}

@Override
public float getFloat(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down Expand Up @@ -127,6 +128,7 @@ public void addEmptyValue()
this.values.add(Float.NaN);
}

@Override
public void aggregateValueInto(int rowIndex, DfColumn sourceColumn, int sourceRowIndex, AggregateFunction aggregator)
{
aggregator.aggregateValueIntoFloat(this, rowIndex, sourceColumn, sourceRowIndex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public ImmutableIntList toIntList()
.toImmutable();
}

@Override
public ValueType getType()
{
return ValueType.INT;
Expand Down Expand Up @@ -65,6 +66,7 @@ public DfColumn mergeWithInto(DfColumn other, DataFrame target)
return mergedCol;
}

@Override
public DfColumn copyTo(DataFrame target)
{
DfIntColumn targetCol = (DfIntColumn) this.copyColumnSchemaAndEnsureCapacity(target);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public void addInt(int anInt, boolean isNullValue)
this.nullMap.add(isNullValue);
}

@Override
public int getInt(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down Expand Up @@ -137,6 +138,7 @@ private void setNull(int rowIndex)
this.nullMap.set(rowIndex, true);
}

@Override
public Object getObject(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public ImmutableLongList toLongList()
.toImmutable();
}

@Override
public ValueType getType()
{
return ValueType.LONG;
Expand Down Expand Up @@ -65,6 +66,7 @@ public DfColumn mergeWithInto(DfColumn other, DataFrame target)
return mergedCol;
}

@Override
public DfColumn copyTo(DataFrame target)
{
DfLongColumn targetCol = (DfLongColumn) this.copyColumnSchemaAndEnsureCapacity(target);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public void addLong(long aLong, boolean isNullValue)
this.nullMap.add(isNullValue);
}

@Override
public long getLong(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down Expand Up @@ -137,6 +138,7 @@ private void setNull(int rowIndex)
this.nullMap.set(rowIndex, true);
}

@Override
public Object getObject(int rowIndex)
{
if (this.isNull(rowIndex))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public DfColumn mergeWithInto(DfColumn other, DataFrame target)
return mergedCol;
}

@Override
public DfColumn copyTo(DataFrame target)
{
DfObjectColumnAbstract<T> targetCol = (DfObjectColumnAbstract<T>) this.copyColumnSchemaAndEnsureCapacity(target);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ default String getValueAsStringLiteral(int rowIndex)
return value == null ? "" : '"' + this.getValueAsString(rowIndex) + '"';
}

@Override
default ValueType getType()
{
return ValueType.STRING;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ public String asString()
}
};

@Override
default Value apply(Value operand1, Value operand2)
{
if (operand1.isVoid() || operand2.isVoid())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public String asString()

ComparisonOp NE = new ComparisonOp()
{
@Override
public BooleanValue apply(Value operand1, Value operand2)
{
if (operand1.isVoid())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public FunctionScript(String newName, ListIterable<String> newParameterNames)
this.parameterNames = newParameterNames;
}

@Override
public String getName()
{
return this.name;
Expand All @@ -43,6 +44,7 @@ public Value evaluate(ExpressionEvaluationVisitor evaluationVisitor)
return evaluationVisitor.visitFunctionScriptExpr(this);
}

@Override
public ListIterable<String> getParameterNames()
{
return this.parameterNames;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
public interface PredicateOp
extends BinaryOp
{
@Override
default BooleanValue apply(Value operand1, Value operand2)
{
if (operand1.isVoid() || operand2.isVoid())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public BooleanValue applyBoolean(boolean operand)
return BooleanValue.valueOf(!operand);
}

@Override
public String asString()
{
return "!";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public IntrinsicFunctionDescriptor(String newName)
this(newName, Lists.immutable.empty());
}

@Override
public String getName()
{
return this.name;
Expand All @@ -44,6 +45,7 @@ protected void setParameterNames(ListIterable<String> newParameterNames)
this.parameterNames = newParameterNames;
}

@Override
public ListIterable<String> getParameterNames()
{
return this.parameterNames;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public ValueType getType()
return ValueType.DECIMAL;
}

@Override
public BigDecimal decimalValue()
{
return this.value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
public record DoubleValue(double value)
implements RealNumberValue
{
@Override
public double doubleValue()
{
return this.value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public float floatValue()
return this.value;
}

@Override
public double doubleValue()
{
return this.value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public long longValue()
return this.value;
}

@Override
public BigDecimal decimalValue()
{
return BigDecimal.valueOf(this.value);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public double doubleValue()
return this.value;
}

@Override
public BigDecimal decimalValue()
{
return BigDecimal.valueOf(this.value);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ public long longInitialValue()
return 0;
}

@Override
public long getLongValue(DfColumn sourceColumn, int sourceRowIndex)
{
return sourceColumn.isNull(sourceRowIndex) ? 1 : 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public SumStringLength(String newColumnName, String newTargetColumnName)
super(newColumnName, newTargetColumnName);
}

@Override
public ListIterable<ValueType> supportedSourceTypes()
{
return Lists.immutable.of(STRING);
Expand Down Expand Up @@ -144,6 +145,7 @@ public Concat(String newColumnName, String newTargetColumnName)
super(newColumnName, newTargetColumnName);
}

@Override
public ListIterable<ValueType> supportedSourceTypes()
{
return Lists.immutable.of(STRING);
Expand Down

0 comments on commit de8a827

Please sign in to comment.