Skip to content

Commit

Permalink
now that we have a simpler structure for the overal CSDiag algorithm,…
Browse files Browse the repository at this point in the history
… change

diagnoseGeneralFailure to be named diagnoseConstraintFailure and change how
it works:
Now it ranks unresolved constraints  in the system based on kind (e.g. whether
they are favored, member constraints ahead of conversion constraints, etc) and
then tries to emit a diagnostic for each failure kind one after another.

This means that if there are multiple failed conversion constraints, but one
is obviously satisfiable, that we continue on to diagnose the next one.  This 
clears up a swath of embarassing diagnostics and refixes:
<rdar://problem/19658691> QoI: Incorrect diagnostic for calling nonexistent members on literals



Swift SVN r31046
  • Loading branch information
lattner committed Aug 6, 2015
1 parent 680b2b0 commit 8c88ebc
Show file tree
Hide file tree
Showing 6 changed files with 141 additions and 177 deletions.
Loading

0 comments on commit 8c88ebc

Please sign in to comment.