Skip to content

Commit

Permalink
Bug 1833998 - Switch Firefox builds to macOS 13.3 SDK. r=firefox-buil…
Browse files Browse the repository at this point in the history
…d-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178500
  • Loading branch information
glandium committed May 25, 2023
1 parent 4e5b262 commit 04d95a1
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build/moz.configure/toolchain.configure
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ with only_when(host_is_osx | target_is_osx):
return Version(obj["Version"])

def sdk_min_version():
return "13.0"
return "13.3"

@depends(
"--with-macos-sdk",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
<plist version="1.0">
<dict>
<key>Version</key>
<string>13.0</string>
<string>13.3</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion taskcluster/ci/toolchain/macos-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ macosx64-sdk-13.0:
- Library/Developer/CommandLineTools/SDKs/MacOSX13.0.sdk
toolchain-artifact: project/gecko/mac-sdk/MacOSX13.0.sdk.tar.zst
toolchain-alias:
- macosx64-sdk
- MacOSX13.0.sdk
resources:
- python/mozbuild/mozpack/macpkg.py
Expand All @@ -49,6 +48,7 @@ macosx64-sdk-13.3:
- Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk
toolchain-artifact: project/gecko/mac-sdk/MacOSX13.3.sdk.tar.zst
toolchain-alias:
- macosx64-sdk
- macosx64-sdk-toolchain
- MacOSX13.3.sdk
resources:
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/scripts/misc/wr-macos-cross-build-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -x -e -v

export TARGET_TRIPLE="x86_64-apple-darwin"

MACOS_SYSROOT="${MOZ_FETCHES_DIR}/MacOSX13.0.sdk"
MACOS_SYSROOT="${MOZ_FETCHES_DIR}/MacOSX13.3.sdk"
CLANGDIR="${MOZ_FETCHES_DIR}/clang"

# Deploy the wrench dependencies
Expand Down
2 changes: 1 addition & 1 deletion widget/cocoa/docs/sdks.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ac_add_options --with-macos-sdk=/Users/username/SDKs/MacOSX11.3.sdk
First off, Firefox runs on 10.12 and above. This is called the "minimum deployment target" and is
independent of the SDK version.

Our official Firefox builds compiled in CI (continuous integration) currently use the 11.3 SDK (last updated in [bug 1788854](https://bugzilla.mozilla.org/show_bug.cgi?id=1788854)). This is also the minimum supported SDK version for local builds.
Our official Firefox builds compiled in CI (continuous integration) currently use the 13.3 SDK (last updated in [bug 1833998](https://bugzilla.mozilla.org/show_bug.cgi?id=1833998)). This is also the minimum supported SDK version for local builds.

Compiling with different SDKs breaks from time to time. Such breakages should be [reported in Bugzilla](https://bugzilla.mozilla.org/enter_bug.cgi?blocked=mach-busted&bug_type=defect&cc=:spohl,:mstange&component=General&form_name=enter_bug&keywords=regression&op_sys=macOS&product=Firefox%20Build%20System&rep_platform=All) and fixed quickly.

Expand Down

0 comments on commit 04d95a1

Please sign in to comment.