Bug 1859588 - Re-enable test_addressDataLoader test and skip test_loa…

…dDataState sub-test r=sgalich

Previously we disabled test_addressDataLoader in Bug 1859590 because
loading a non-existent resource could potentially cause a crash.

This patch re-enables the test and only disables the sub-test that
caused a crash.

Differential Revision: https://phabricator.services.mozilla.com/D198008

browser/extensions/formautofill/test/unit/test_addressDataLoader.js

@@ -30,7 +30,7 @@ add_task(async function test_initalState() {
   Assert.equal(AddressDataLoader._dataLoaded.level1.size, 0);
 });
 
-add_task(async function test_loadDataState() {
+add_task(async function test_loadDataCountry() {
   sinon.spy(AddressDataLoader, "_loadScripts");
   let metadata = FormAutofillUtils.getCountryAddressData("US");
   Assert.ok(AddressDataLoader._addressData, "addressData exists");
@@ -57,7 +57,15 @@ add_task(async function test_loadDataState() {
     "metadata should be US if country is not specified"
   );
   AddressDataLoader._loadScripts.resetHistory();
+});
 
+// This test is currently Disable!
+// This is because - Loading a non-existent resource could potentially cause a crash
+// (See Bug 1859588). To address this issue, We can check for the file's existence
+// before attempting to load the script. However, given that we are not using
+// state data, just keep the solution simple by disabling the test.
+add_task(async function test_loadDataState() {
+  sinon.spy(AddressDataLoader, "_loadScripts");
   // Load level 1 data that does not exist
   let undefinedMetadata = FormAutofillUtils.getCountryAddressData("US", "CA");
   // _loadScripts should be called
@@ -74,7 +82,7 @@ add_task(async function test_loadDataState() {
   Assert.equal(undefinedMetadata, undefined, "metadata should be undefined");
   // _loadScripts should not be called
   sinon.assert.notCalled(AddressDataLoader._loadScripts);
-});
+}).skip();
 
 SUPPORT_COUNTRIES_TESTCASES.forEach(testcase => {
   add_task(async function test_support_country() {

browser/extensions/formautofill/test/unit/xpcshell.toml

@@ -38,7 +38,6 @@ head = "head_addressComponent.js"
 head = "head_addressComponent.js"
 
 ["test_addressDataLoader.js"]
-skip-if = ["true"] # bug 1859588
 
 ["test_addressRecords.js"]
 skip-if = ["apple_silicon"] # bug 1729554