Skip to content

Commit

Permalink
Bug 1879731: Address clang-tidy concerns in BCMapCellIterator. r=layo…
Browse files Browse the repository at this point in the history
…ut-reviewers,emilio

Differential Revision: https://phabricator.services.mozilla.com/D202316
  • Loading branch information
dshin-moz committed Feb 27, 2024
1 parent 9184cb6 commit 0c24333
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions layout/tables/nsTableFrame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3903,14 +3903,14 @@ class BCMapCellIterator {
public:
BCMapCellIterator(nsTableFrame* aTableFrame, const TableArea& aDamageArea);

void First(BCMapCellInfo& aMapCellInfo);
void First(BCMapCellInfo& aMapInfo);

void Next(BCMapCellInfo& aMapCellInfo);
void Next(BCMapCellInfo& aMapInfo);

void PeekIEnd(const BCMapCellInfo& aRefInfo, uint32_t aRowIndex,
void PeekIEnd(const BCMapCellInfo& aRefInfo, int32_t aRowIndex,
BCMapCellInfo& aAjaInfo);

void PeekBEnd(const BCMapCellInfo& aRefInfo, uint32_t aColIndex,
void PeekBEnd(const BCMapCellInfo& aRefInfo, int32_t aColIndex,
BCMapCellInfo& aAjaInfo);

void PeekIStart(const BCMapCellInfo& aRefInfo, int32_t aRowIndex,
Expand Down Expand Up @@ -4190,13 +4190,13 @@ void BCMapCellIterator::Next(BCMapCellInfo& aMapInfo) {
}

void BCMapCellIterator::PeekIEnd(const BCMapCellInfo& aRefInfo,
uint32_t aRowIndex, BCMapCellInfo& aAjaInfo) {
PeekIAt(aRefInfo, static_cast<int32_t>(aRowIndex),
aRefInfo.mColIndex + aRefInfo.mColSpan, aAjaInfo);
int32_t aRowIndex, BCMapCellInfo& aAjaInfo) {
PeekIAt(aRefInfo, aRowIndex, aRefInfo.mColIndex + aRefInfo.mColSpan,
aAjaInfo);
}

void BCMapCellIterator::PeekBEnd(const BCMapCellInfo& aRefInfo,
uint32_t aColIndex, BCMapCellInfo& aAjaInfo) {
int32_t aColIndex, BCMapCellInfo& aAjaInfo) {
aAjaInfo.ResetCellInfo();
int32_t rowIndex = aRefInfo.mRowIndex + aRefInfo.mRowSpan;
int32_t rgRowIndex = rowIndex - mRowGroupStart;
Expand Down Expand Up @@ -4236,7 +4236,7 @@ void BCMapCellIterator::PeekBEnd(const BCMapCellInfo& aRefInfo,
if (!cellData) ABORT0();
}
if (cellData->IsColSpan()) {
aColIndex -= cellData->GetColSpanOffset();
aColIndex -= static_cast<int32_t>(cellData->GetColSpanOffset());
cellData =
static_cast<BCCellData*>(cellMap->GetDataAt(rgRowIndex, aColIndex));
}
Expand Down

0 comments on commit 0c24333

Please sign in to comment.