Skip to content

Commit

Permalink
Bug 1606604 - [remote] Disable experimental SameSite=Lax by default. …
Browse files Browse the repository at this point in the history
…r=remote-protocol-reviewers,jgraham

Differential Revision: https://phabricator.services.mozilla.com/D100168
  • Loading branch information
whimboo committed Dec 21, 2020
1 parent 7326b3c commit 0d33e4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 3 additions & 3 deletions remote/puppeteer-expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
"PASS"
],
"Cookie specs Page.cookies should get a cookie (cookies.spec.ts)": [
"FAIL"
"PASS"
],
"Cookie specs Page.cookies should properly report httpOnly cookie (cookies.spec.ts)": [
"PASS"
Expand All @@ -195,7 +195,7 @@
"PASS"
],
"Cookie specs Page.cookies should get multiple cookies (cookies.spec.ts)": [
"FAIL"
"PASS"
],
"Cookie specs Page.cookies should get cookies from multiple urls (cookies.spec.ts)": [
"FAIL"
Expand Down Expand Up @@ -246,7 +246,7 @@
"FAIL"
],
"DefaultBrowserContext page.cookies() should work (defaultbrowsercontext.spec.ts)": [
"FAIL"
"PASS"
],
"DefaultBrowserContext page.setCookie() should work (defaultbrowsercontext.spec.ts)": [
"FAIL"
Expand Down
3 changes: 3 additions & 0 deletions remote/test/puppeteer/src/node/Launcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,9 @@ class FirefoxLauncher implements ProductLauncher {
// jest-puppeteer asserts that no error message is emitted by the console
'network.cookie.cookieBehavior': 0,

// Disable experimental feature that is only available in Nightly
'network.cookie.sameSite.laxByDefault': false,

// Do not prompt for temporary redirects
'network.http.prompt-temp-redirect': false,

Expand Down

0 comments on commit 0d33e4d

Please sign in to comment.