Bug 1871991 - Required arguments after optional are not supported r=j…

…esup I reviewed all js callsites, and they always use all arguments, so this should be no-op. Differential Revision: https://phabricator.services.mozilla.com/D197300
dothq · Jan 4, 2024 · 11996c6 · 11996c6
1 parent 5c97317
commit 11996c6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/storage/mozIStorageService.idl b/storage/mozIStorageService.idl
@@ -119,13 +119,13 @@ interface mozIStorageService : nsISupports {
    * string may be:
    * - "memory" to open an in-memory database.
    *
-   * @param [optional] aOpenFlags
+   * @param aOpenFlags
    *        A set of flags to open the database with optional features.
    *        Currently supports OPEN_SHARED, OPEN_READONLY and
    *        OPEN_IGNORE_LOCKING_MODE flags.
    *        For full details, please refer to the documentation of the flags.
    *
-   * @param [optional] aConnectionFlags
+   * @param aConnectionFlags
    *        A set of flags to enable optional features for the returned
    *        asynchronous connection object.
    *        Currently supports CONNECTION_INTERRUPTIBLE flag.
@@ -146,8 +146,8 @@ interface mozIStorageService : nsISupports {
    *         main thread.
    */
   void openAsyncDatabase(in nsIVariant aDatabaseStore,
-                         [optional] in unsigned long aOpenFlags,
-                         [optional] in unsigned long aConnectionFlags,
+                         in unsigned long aOpenFlags,
+                         in unsigned long aConnectionFlags,
                          in mozIStorageCompletionCallback aCallback);
 
   /**

diff --git a/toolkit/components/alerts/nsIAlertsService.idl b/toolkit/components/alerts/nsIAlertsService.idl
@@ -331,8 +331,8 @@ interface nsIAlertsIconData : nsISupports
    * |aIconSize| will be zero.
   */
   void showAlertWithIconData(in nsIAlertNotification aAlert,
-                             [optional] in nsIObserver aAlertListener,
-                             [optional] in uint32_t aIconSize,
+                             in nsIObserver aAlertListener,
+                             in uint32_t aIconSize,
                              [const, array, size_is(aIconSize)] in uint8_t
                                                                 aIconData);
 };

diff --git a/uriloader/base/nsITransfer.idl b/uriloader/base/nsITransfer.idl
@@ -103,7 +103,7 @@ interface nsITransfer : nsIWebProgressListener2 {
                                     in boolean aIsPrivate,
                                     in long aDownloadClassification,
                                     in nsIReferrerInfo aReferrerInfo,
-                                    [optional] in boolean aOpenDownloadsListOnStart,
+                                    in boolean aOpenDownloadsListOnStart,
                                     in BrowsingContext aBrowsingContext,
                                     in boolean aHandleInternally,
                                     in nsIHttpChannel aHttpChannel);