Skip to content

Commit

Permalink
Backed out changesets dcdb85fc5517, 702bca0deee2, 9cKX8gC1ATA (bug 12…
Browse files Browse the repository at this point in the history
…93739) for build bustage; a=bustage

The merge from inbound to central conflicted with the merge from
autoland to central, it appears. Per tree rules, the commit from the
autoland repo wins and the inbound commit gets backed out.

CLOSED TREE

--HG--
extra : amend_source : 927e1cdfa8e55ccbd873d404d905caf6871c8c4f
extra : histedit_source : 07095868c3f767258e1d7d2645193bf4811b13bb%2Ca49ae5a28bf6e67298b6208ee9254c25a2539712
  • Loading branch information
indygreg committed Aug 17, 2016
1 parent 1df863d commit 1794619
Show file tree
Hide file tree
Showing 90 changed files with 758 additions and 758 deletions.
8 changes: 4 additions & 4 deletions dom/animation/AnimValuesStyleRule.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
#define mozilla_AnimValuesStyleRule_h

#include "mozilla/StyleAnimationValue.h"
#include "nsCSSPropertyID.h"
#include "nsCSSPropertyIDSet.h"
#include "nsCSSProperty.h"
#include "nsCSSPropertySet.h"
#include "nsIStyleRule.h"
#include "nsISupportsImpl.h" // For NS_DECL_ISUPPORTS
#include "nsRuleNode.h" // For nsCachedStyleData
Expand Down Expand Up @@ -38,15 +38,15 @@ class AnimValuesStyleRule final : public nsIStyleRule
void List(FILE* out = stdout, int32_t aIndent = 0) const override;
#endif

void AddValue(nsCSSPropertyID aProperty, const StyleAnimationValue &aStartValue)
void AddValue(nsCSSProperty aProperty, const StyleAnimationValue &aStartValue)
{
PropertyStyleAnimationValuePair pair = { aProperty, aStartValue };
mPropertyValuePairs.AppendElement(pair);
mStyleBits |=
nsCachedStyleData::GetBitForSID(nsCSSProps::kSIDTable[aProperty]);
}

void AddValue(nsCSSPropertyID aProperty, StyleAnimationValue&& aStartValue)
void AddValue(nsCSSProperty aProperty, StyleAnimationValue&& aStartValue)
{
PropertyStyleAnimationValuePair* pair = mPropertyValuePairs.AppendElement();
pair->mProperty = aProperty;
Expand Down
2 changes: 1 addition & 1 deletion dom/animation/Animation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ Animation::HasLowerCompositeOrderThan(const Animation& aOther) const

void
Animation::ComposeStyle(RefPtr<AnimValuesStyleRule>& aStyleRule,
nsCSSPropertyIDSet& aSetProperties)
nsCSSPropertySet& aSetProperties)
{
if (!mEffect) {
return;
Expand Down
6 changes: 3 additions & 3 deletions dom/animation/Animation.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "mozilla/DOMEventTargetHelper.h" // for DOMEventTargetHelper
#include "mozilla/dom/KeyframeEffect.h" // for KeyframeEffectReadOnly
#include "mozilla/dom/Promise.h" // for Promise
#include "nsCSSPropertyID.h" // for nsCSSPropertyID
#include "nsCSSProperty.h" // for nsCSSProperty
#include "nsIGlobalObject.h"

// X11 has a #define for CurrentTime.
Expand All @@ -33,7 +33,7 @@
#endif

struct JSContext;
class nsCSSPropertyIDSet;
class nsCSSPropertySet;
class nsIDocument;
class nsPresContext;

Expand Down Expand Up @@ -313,7 +313,7 @@ class Animation
* properties that are changed are added to |aSetProperties|.
*/
void ComposeStyle(RefPtr<AnimValuesStyleRule>& aStyleRule,
nsCSSPropertyIDSet& aSetProperties);
nsCSSPropertySet& aSetProperties);

void NotifyEffectTimingUpdated();

Expand Down
24 changes: 12 additions & 12 deletions dom/animation/EffectCompositor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "mozilla/RestyleManagerHandle.h"
#include "mozilla/RestyleManagerHandleInlines.h"
#include "nsComputedDOMStyle.h" // nsComputedDOMStyle::GetPresShellForContent
#include "nsCSSPropertyIDSet.h"
#include "nsCSSPropertySet.h"
#include "nsCSSProps.h"
#include "nsIPresShell.h"
#include "nsLayoutUtils.h"
Expand Down Expand Up @@ -61,7 +61,7 @@ NS_IMPL_CYCLE_COLLECTION_UNROOT_NATIVE(EffectCompositor, Release)
// Returns true if there are eligible animations, false otherwise.
bool
FindAnimationsForCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty,
nsCSSProperty aProperty,
nsTArray<RefPtr<dom::Animation>>* aMatches /*out*/)
{
MOZ_ASSERT(!aMatches || aMatches->IsEmpty(),
Expand Down Expand Up @@ -433,14 +433,14 @@ EffectCompositor::AddStyleUpdatesTo(RestyleTracker& aTracker)

/* static */ bool
EffectCompositor::HasAnimationsForCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty)
nsCSSProperty aProperty)
{
return FindAnimationsForCompositor(aFrame, aProperty, nullptr);
}

/* static */ nsTArray<RefPtr<dom::Animation>>
EffectCompositor::GetAnimationsForCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty)
nsCSSProperty aProperty)
{
nsTArray<RefPtr<dom::Animation>> result;

Expand All @@ -456,7 +456,7 @@ EffectCompositor::GetAnimationsForCompositor(const nsIFrame* aFrame,

/* static */ void
EffectCompositor::ClearIsRunningOnCompositor(const nsIFrame *aFrame,
nsCSSPropertyID aProperty)
nsCSSProperty aProperty)
{
EffectSet* effects = EffectSet::GetEffectSet(aFrame);
if (!effects) {
Expand Down Expand Up @@ -598,7 +598,7 @@ EffectCompositor::ComposeAnimationRule(dom::Element* aElement,
// animation with the *highest* composite order wins.
// As a result, we iterate from last animation to first and, if a
// property has already been set, we don't change it.
nsCSSPropertyIDSet properties;
nsCSSPropertySet properties;

for (KeyframeEffectReadOnly* effect : Reversed(sortedEffectList)) {
effect->GetAnimation()->ComposeStyle(animationRule, properties);
Expand All @@ -613,12 +613,12 @@ EffectCompositor::ComposeAnimationRule(dom::Element* aElement,
/* static */ void
EffectCompositor::GetOverriddenProperties(nsStyleContext* aStyleContext,
EffectSet& aEffectSet,
nsCSSPropertyIDSet&
nsCSSPropertySet&
aPropertiesOverridden)
{
AutoTArray<nsCSSPropertyID, LayerAnimationInfo::kRecords> propertiesToTrack;
AutoTArray<nsCSSProperty, LayerAnimationInfo::kRecords> propertiesToTrack;
{
nsCSSPropertyIDSet propertiesToTrackAsSet;
nsCSSPropertySet propertiesToTrackAsSet;
for (KeyframeEffectReadOnly* effect : aEffectSet) {
for (const AnimationProperty& property : effect->Properties()) {
if (nsCSSProps::PropHasFlags(property.mProperty,
Expand Down Expand Up @@ -670,13 +670,13 @@ EffectCompositor::UpdateCascadeResults(EffectSet& aEffectSet,
// We only do this for properties that we can animate on the compositor
// since we will apply other properties on the main thread where the usual
// cascade applies.
nsCSSPropertyIDSet overriddenProperties;
nsCSSPropertySet overriddenProperties;
if (aStyleContext) {
GetOverriddenProperties(aStyleContext, aEffectSet, overriddenProperties);
}

bool changed = false;
nsCSSPropertyIDSet animatedProperties;
nsCSSPropertySet animatedProperties;

// Iterate from highest to lowest composite order.
for (KeyframeEffectReadOnly* effect : Reversed(sortedEffectList)) {
Expand Down Expand Up @@ -748,7 +748,7 @@ EffectCompositor::GetPresContext(Element* aElement)
/* static */ void
EffectCompositor::SetPerformanceWarning(
const nsIFrame *aFrame,
nsCSSPropertyID aProperty,
nsCSSProperty aProperty,
const AnimationPerformanceWarning& aWarning)
{
EffectSet* effects = EffectSet::GetEffectSet(aFrame);
Expand Down
14 changes: 7 additions & 7 deletions dom/animation/EffectCompositor.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
#include "mozilla/OwningNonNull.h"
#include "mozilla/PseudoElementHashEntry.h"
#include "mozilla/RefPtr.h"
#include "nsCSSPropertyID.h"
#include "nsCSSProperty.h"
#include "nsCycleCollectionParticipant.h"
#include "nsDataHashtable.h"
#include "nsIStyleRuleProcessor.h"
#include "nsTArray.h"

class nsCSSPropertyIDSet;
class nsCSSPropertySet;
class nsIFrame;
class nsIStyleRule;
class nsPresContext;
Expand Down Expand Up @@ -162,14 +162,14 @@ class EffectCompositor
}

static bool HasAnimationsForCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty);
nsCSSProperty aProperty);

static nsTArray<RefPtr<dom::Animation>>
GetAnimationsForCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty);
nsCSSProperty aProperty);

static void ClearIsRunningOnCompositor(const nsIFrame* aFrame,
nsCSSPropertyID aProperty);
nsCSSProperty aProperty);

// Update animation cascade results for the specified (pseudo-)element
// but only if we have marked the cascade as needing an update due a
Expand Down Expand Up @@ -212,7 +212,7 @@ class EffectCompositor
// |aProperty|.
static void SetPerformanceWarning(
const nsIFrame* aFrame,
nsCSSPropertyID aProperty,
nsCSSProperty aProperty,
const AnimationPerformanceWarning& aWarning);

private:
Expand All @@ -235,7 +235,7 @@ class EffectCompositor
static void
GetOverriddenProperties(nsStyleContext* aStyleContext,
EffectSet& aEffectSet,
nsCSSPropertyIDSet& aPropertiesOverridden);
nsCSSPropertySet& aPropertiesOverridden);

static void
UpdateCascadeResults(EffectSet& aEffectSet,
Expand Down
22 changes: 11 additions & 11 deletions dom/animation/KeyframeEffect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "Layers.h" // For Layer
#include "nsComputedDOMStyle.h" // nsComputedDOMStyle::GetStyleContextForElement
#include "nsContentUtils.h" // nsContentUtils::ReportToConsole
#include "nsCSSPropertyIDSet.h"
#include "nsCSSPropertySet.h"
#include "nsCSSProps.h" // For nsCSSProps::PropHasFlags
#include "nsCSSPseudoElements.h" // For CSSPseudoElementType
#include "nsDOMMutationObserver.h" // For nsAutoAnimationMutationBatch
Expand Down Expand Up @@ -492,7 +492,7 @@ KeyframeEffectReadOnly::SetKeyframes(nsTArray<Keyframe>&& aKeyframes,
}

const AnimationProperty*
KeyframeEffectReadOnly::GetAnimationOfProperty(nsCSSPropertyID aProperty) const
KeyframeEffectReadOnly::GetAnimationOfProperty(nsCSSProperty aProperty) const
{
for (size_t propIdx = 0, propEnd = mProperties.Length();
propIdx != propEnd; ++propIdx) {
Expand Down Expand Up @@ -575,8 +575,8 @@ KeyframeEffectReadOnly::UpdateProperties(nsStyleContext* aStyleContext)
}

// Preserve the state of mWinsInCascade and mIsRunningOnCompositor flags.
nsCSSPropertyIDSet winningInCascadeProperties;
nsCSSPropertyIDSet runningOnCompositorProperties;
nsCSSPropertySet winningInCascadeProperties;
nsCSSPropertySet runningOnCompositorProperties;

for (const AnimationProperty& property : mProperties) {
if (property.mWinsInCascade) {
Expand Down Expand Up @@ -611,7 +611,7 @@ KeyframeEffectReadOnly::UpdateProperties(nsStyleContext* aStyleContext)

void
KeyframeEffectReadOnly::ComposeStyle(RefPtr<AnimValuesStyleRule>& aStyleRule,
nsCSSPropertyIDSet& aSetProperties)
nsCSSPropertySet& aSetProperties)
{
ComputedTiming computedTiming = GetComputedTiming();
mProgressOnLastCompose = computedTiming.mProgress;
Expand Down Expand Up @@ -725,7 +725,7 @@ KeyframeEffectReadOnly::IsRunningOnCompositor() const
}

void
KeyframeEffectReadOnly::SetIsRunningOnCompositor(nsCSSPropertyID aProperty,
KeyframeEffectReadOnly::SetIsRunningOnCompositor(nsCSSProperty aProperty,
bool aIsRunning)
{
MOZ_ASSERT(nsCSSProps::PropHasFlags(aProperty,
Expand Down Expand Up @@ -1005,7 +1005,7 @@ KeyframeEffectReadOnly::GetTarget(
}

static void
CreatePropertyValue(nsCSSPropertyID aProperty,
CreatePropertyValue(nsCSSProperty aProperty,
float aOffset,
const Maybe<ComputedTimingFunction>& aTimingFunction,
const StyleAnimationValue& aValue,
Expand Down Expand Up @@ -1132,7 +1132,7 @@ KeyframeEffectReadOnly::GetKeyframes(JSContext*& aCx,
// nsCSSValue::AppendToString does not accept shorthands properties but
// works with token stream values if we pass eCSSProperty_UNKNOWN as
// the property.
nsCSSPropertyID propertyForSerializing =
nsCSSProperty propertyForSerializing =
nsCSSProps::IsShorthand(propertyValue.mProperty)
? eCSSProperty_UNKNOWN
: propertyValue.mProperty;
Expand Down Expand Up @@ -1352,7 +1352,7 @@ KeyframeEffectReadOnly::GetPresContext() const

/* static */ bool
KeyframeEffectReadOnly::IsGeometricProperty(
const nsCSSPropertyID aProperty)
const nsCSSProperty aProperty)
{
switch (aProperty) {
case eCSSProperty_bottom:
Expand Down Expand Up @@ -1438,7 +1438,7 @@ KeyframeEffectReadOnly::ShouldBlockAsyncTransformAnimations(

void
KeyframeEffectReadOnly::SetPerformanceWarning(
nsCSSPropertyID aProperty,
nsCSSProperty aProperty,
const AnimationPerformanceWarning& aWarning)
{
for (AnimationProperty& property : mProperties) {
Expand All @@ -1459,7 +1459,7 @@ KeyframeEffectReadOnly::SetPerformanceWarning(
}

static already_AddRefed<nsStyleContext>
CreateStyleContextForAnimationValue(nsCSSPropertyID aProperty,
CreateStyleContextForAnimationValue(nsCSSProperty aProperty,
StyleAnimationValue aValue,
nsStyleContext* aBaseStyleContext)
{
Expand Down
20 changes: 10 additions & 10 deletions dom/animation/KeyframeEffect.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#define mozilla_dom_KeyframeEffect_h

#include "nsChangeHint.h"
#include "nsCSSPropertyID.h"
#include "nsCSSProperty.h"
#include "nsCSSValue.h"
#include "nsCycleCollectionParticipant.h"
#include "nsTArray.h"
Expand All @@ -32,7 +32,7 @@
#include "mozilla/dom/Nullable.h"

struct JSContext;
class nsCSSPropertyIDSet;
class nsCSSPropertySet;
class nsIContent;
class nsIDocument;
class nsIFrame;
Expand All @@ -59,7 +59,7 @@ struct AnimationPropertyDetails;
*/
struct PropertyValuePair
{
nsCSSPropertyID mProperty;
nsCSSProperty mProperty;
// The specified value for the property. For shorthand properties or invalid
// property values, we store the specified property value as a token stream
// (string).
Expand Down Expand Up @@ -134,7 +134,7 @@ struct AnimationPropertySegment

struct AnimationProperty
{
nsCSSPropertyID mProperty = eCSSProperty_UNKNOWN;
nsCSSProperty mProperty = eCSSProperty_UNKNOWN;

// Does this property win in the CSS Cascade?
//
Expand Down Expand Up @@ -290,8 +290,8 @@ class KeyframeEffectReadOnly : public AnimationEffectReadOnly
void SetKeyframes(nsTArray<Keyframe>&& aKeyframes,
nsStyleContext* aStyleContext);
const AnimationProperty*
GetAnimationOfProperty(nsCSSPropertyID aProperty) const;
bool HasAnimationOfProperty(nsCSSPropertyID aProperty) const {
GetAnimationOfProperty(nsCSSProperty aProperty) const;
bool HasAnimationOfProperty(nsCSSProperty aProperty) const {
return GetAnimationOfProperty(aProperty) != nullptr;
}
const InfallibleTArray<AnimationProperty>& Properties() const {
Expand All @@ -310,10 +310,10 @@ class KeyframeEffectReadOnly : public AnimationEffectReadOnly
// contained in |aSetProperties|.
// Any updated properties are added to |aSetProperties|.
void ComposeStyle(RefPtr<AnimValuesStyleRule>& aStyleRule,
nsCSSPropertyIDSet& aSetProperties);
nsCSSPropertySet& aSetProperties);
// Returns true if at least one property is being animated on compositor.
bool IsRunningOnCompositor() const;
void SetIsRunningOnCompositor(nsCSSPropertyID aProperty, bool aIsRunning);
void SetIsRunningOnCompositor(nsCSSProperty aProperty, bool aIsRunning);
void ResetIsRunningOnCompositor();

// Returns true if this effect, applied to |aFrame|, contains properties
Expand All @@ -338,7 +338,7 @@ class KeyframeEffectReadOnly : public AnimationEffectReadOnly
// compositor. |aParams| and |aParamsLength| are optional parameters which
// will be used to generate a localized message for devtools.
void SetPerformanceWarning(
nsCSSPropertyID aProperty,
nsCSSProperty aProperty,
const AnimationPerformanceWarning& aWarning);

// Cumulative change hint on each segment for each property.
Expand Down Expand Up @@ -434,7 +434,7 @@ class KeyframeEffectReadOnly : public AnimationEffectReadOnly
static bool CanAnimateTransformOnCompositor(
const nsIFrame* aFrame,
AnimationPerformanceWarning::Type& aPerformanceWarning);
static bool IsGeometricProperty(const nsCSSPropertyID aProperty);
static bool IsGeometricProperty(const nsCSSProperty aProperty);

static const TimeDuration OverflowRegionRefreshInterval();
};
Expand Down
2 changes: 1 addition & 1 deletion dom/animation/KeyframeEffectParams.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ ConsumeIdentToken(RangedPtr<const char16_t>& aIter,
/* static */ void
KeyframeEffectParams::ParseSpacing(const nsAString& aSpacing,
SpacingMode& aSpacingMode,
nsCSSPropertyID& aPacedProperty,
nsCSSProperty& aPacedProperty,
nsAString& aInvalidPacedProperty,
ErrorResult& aRv)
{
Expand Down
Loading

0 comments on commit 1794619

Please sign in to comment.