Bug 788276 - Properly check for broken (deprecated) compilers. r=gps.

Check for old gcc versions.
dothq · Sep 12, 2012 · 1886002 · 1886002
1 parent 3d13bf4
commit 1886002
Show file tree

Hide file tree

Showing 6 changed files with 78 additions and 0 deletions.
diff --git a/aclocal.m4 b/aclocal.m4
@@ -17,6 +17,7 @@ builtin(include, build/autoconf/mozcommonheader.m4)dnl
 builtin(include, build/autoconf/acwinpaths.m4)dnl
 builtin(include, build/autoconf/lto.m4)dnl
 builtin(include, build/autoconf/gcc-pr49911.m4)dnl
+builtin(include, build/autoconf/gcc-pr39608.m4)dnl
 builtin(include, build/autoconf/llvm-pr8927.m4)dnl
 builtin(include, build/autoconf/frameptr.m4)dnl
 builtin(include, build/autoconf/compiler-opts.m4)dnl

diff --git a/build/autoconf/gcc-pr39608.m4 b/build/autoconf/gcc-pr39608.m4
@@ -0,0 +1,37 @@
+dnl This Source Code Form is subject to the terms of the Mozilla Public
+dnl License, v. 2.0. If a copy of the MPL was not distributed with this
+dnl file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+dnl Check if the compiler is gcc and has pr39608. If so
+dnl disable vrp.
+
+AC_DEFUN([MOZ_GCC_PR39608],
+[
+AC_MSG_CHECKING(for gcc pr39608)
+ac_have_gcc_pr39608="yes"
+AC_LANG_SAVE
+AC_LANG_CPLUSPLUS
+
+AC_TRY_COMPILE([
+typedef void (*FuncType)();
+template<FuncType Impl>
+void f();
+template<typename T> class C {
+  typedef C<T> ThisC;
+  template<int g()>
+  static void h() {
+    f<ThisC::h<g> >();
+  }
+};
+], true,
+   ac_have_gcc_pr39608="no",
+   true)
+
+AC_LANG_RESTORE
+
+AC_MSG_RESULT($ac_have_gcc_pr39608)
+if test "$ac_have_gcc_pr39608" = "yes"; then
+   echo This compiler would fail to build firefox, plase upgrade.
+   exit 1
+fi
+])
diff --git a/configure.in b/configure.in
@@ -2944,6 +2944,7 @@ AC_SUBST(WRAP_SYSTEM_INCLUDES)
 AC_SUBST(VISIBILITY_FLAGS)
 
 MOZ_GCC_PR49911
+MOZ_GCC_PR39608
 MOZ_LLVM_PR8927
 
 dnl Check for __force_align_arg_pointer__ for SSE2 on gcc

diff --git a/js/src/aclocal.m4 b/js/src/aclocal.m4
@@ -16,6 +16,7 @@ builtin(include, build/autoconf/mozcommonheader.m4)dnl
 builtin(include, build/autoconf/acwinpaths.m4)dnl
 builtin(include, build/autoconf/lto.m4)dnl
 builtin(include, build/autoconf/gcc-pr49911.m4)dnl
+builtin(include, build/autoconf/gcc-pr39608.m4)dnl
 builtin(include, build/autoconf/llvm-pr8927.m4)dnl
 builtin(include, build/autoconf/frameptr.m4)dnl
 builtin(include, build/autoconf/compiler-opts.m4)dnl

diff --git a/js/src/build/autoconf/gcc-pr39608.m4 b/js/src/build/autoconf/gcc-pr39608.m4
@@ -0,0 +1,37 @@
+dnl This Source Code Form is subject to the terms of the Mozilla Public
+dnl License, v. 2.0. If a copy of the MPL was not distributed with this
+dnl file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+dnl Check if the compiler is gcc and has pr39608. If so
+dnl disable vrp.
+
+AC_DEFUN([MOZ_GCC_PR39608],
+[
+AC_MSG_CHECKING(for gcc pr39608)
+ac_have_gcc_pr39608="yes"
+AC_LANG_SAVE
+AC_LANG_CPLUSPLUS
+
+AC_TRY_COMPILE([
+typedef void (*FuncType)();
+template<FuncType Impl>
+void f();
+template<typename T> class C {
+  typedef C<T> ThisC;
+  template<int g()>
+  static void h() {
+    f<ThisC::h<g> >();
+  }
+};
+], true,
+   ac_have_gcc_pr39608="no",
+   true)
+
+AC_LANG_RESTORE
+
+AC_MSG_RESULT($ac_have_gcc_pr39608)
+if test "$ac_have_gcc_pr39608" = "yes"; then
+   echo This compiler would fail to build firefox, plase upgrade.
+   exit 1
+fi
+])
diff --git a/js/src/configure.in b/js/src/configure.in
@@ -2527,6 +2527,7 @@ AC_SUBST(WRAP_SYSTEM_INCLUDES)
 AC_SUBST(VISIBILITY_FLAGS)
 
 MOZ_GCC_PR49911
+MOZ_GCC_PR39608
 MOZ_LLVM_PR8927
 
 dnl Checks for header files.