Bug 1869970 - Make snap builds pick minidump-stackwalk in case PGO cr…

…ashes. r=firefox-build-system-reviewers,ahochheiden

We use UPLOAD_DIR rather than UPLOAD_PATH because UPLOAD_DIR is handled
by run-task to be set properly from a relative path.

As the snaps rightfully unset MOZ_AUTOMATION, we add another way to
enable the use of the symbols server.

Differential Revision: https://phabricator.services.mozilla.com/D196399

build/pgo/profileserver.py

@@ -33,6 +33,8 @@
 def get_crashreports(directory, name=None):
     rc = 0
     upload_path = os.environ.get("UPLOAD_PATH")
+    if not upload_path:
+        upload_path = os.environ.get("UPLOAD_DIR")
     if upload_path:
         # For automation, log the minidumps with stackwalk and get them moved to
         # the artifacts directory.

taskcluster/ci/snap-upstream-build/kind.yml

@@ -31,6 +31,11 @@ job-defaults:
         max-run-time: 900
         env:
             MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE: system
+            UPLOAD_DIR: artifacts
+            MOZ_STACKWALK_SYMBOLS_SERVER: '1'
+    fetches:
+        toolchain:
+            - linux64-minidump-stackwalk
 
 jobs:
     amd64-nightly/opt:

testing/mozbase/mozcrash/mozcrash/mozcrash.py

@@ -386,7 +386,10 @@ def _process_dump_file(self, path, extra):
 
             # Fallback to the symbols server for unknown symbols on automation
             # (mostly for system libraries).
-            if "MOZ_AUTOMATION" in os.environ:
+            if (
+                "MOZ_AUTOMATION" in os.environ
+                or "MOZ_STACKWALK_SYMBOLS_SERVER" in os.environ
+            ):
                 command.append("--symbols-url=https://symbols.mozilla.org/")
 
             with tempfile.TemporaryDirectory() as json_dir: