Skip to content

Commit

Permalink
Bug 1793882 - Don't "return" c_void in NS_NewHashPropertyBag declarat…
Browse files Browse the repository at this point in the history
…ion. r=emilio

A function that "returns" c_void in rust ends up transposed as returning
a bool (i1) at the LLVM-IR level, compared to the definition in C/C++
returning a void at the LLVM-IR level.

Differential Revision: https://phabricator.services.mozilla.com/D158722
  • Loading branch information
glandium committed Oct 6, 2022
1 parent efbdf62 commit 1d8e8ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/variant/src/bag.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use xpcom::{
use crate::{NsIVariantExt, VariantType};

extern "C" {
fn NS_NewHashPropertyBag(bag: *mut *const nsIWritablePropertyBag) -> libc::c_void;
fn NS_NewHashPropertyBag(bag: *mut *const nsIWritablePropertyBag);
}

/// A hash property bag backed by storage variant values.
Expand Down

0 comments on commit 1d8e8ba

Please sign in to comment.