Skip to content

Commit

Permalink
Bug 1882430 - Ensure isUnlabeledUrlBarOption is checked before failin…
Browse files Browse the repository at this point in the history
…g the label check in AccessibilityUtils. r=Jamie

Adding the check in one more place that is failing on Linux.

This should resolve the failing of `browser/components/urlbar/tests/browser/browser_acknowledgeFeedbackAndDismissal.js` test with a11y-checks jobs, thus removing the temporary `fail-if` notation from its test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D202897
  • Loading branch information
anna-yeddi committed Mar 8, 2024
1 parent 6d213f3 commit 1e1d649
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 0 additions & 1 deletion browser/components/urlbar/tests/browser/browser.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ skip-if = [
]

["browser_acknowledgeFeedbackAndDismissal.js"]
fail-if = ["a11y_checks"] # Bug 1882430 while the general patch is under review

["browser_action_searchengine.js"]
skip-if = [
Expand Down
6 changes: 5 additions & 1 deletion testing/mochitest/tests/SimpleTest/AccessibilityUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,11 @@ this.AccessibilityUtils = (function () {
if (gEnv.labelRule && !name) {
// The URL and Search Bar comboboxes are purposefully unlabeled,
// since they include labeled inputs that are receiving focus.
if (isUnlabeledUrlBarCombobox(DOMNode)) {
// Or the Accessible died because the DOM node was removed or hidden.
if (
isUnlabeledUrlBarCombobox(DOMNode) ||
isUnlabeledUrlBarOption(DOMNode)
) {
return;
}
a11yFail("Interactive elements must be labeled", accessible);
Expand Down

0 comments on commit 1e1d649

Please sign in to comment.