Skip to content

Commit

Permalink
Bug 1506759: remove try-except block which swallows OSError r=ted
Browse files Browse the repository at this point in the history
We have a few bugs filed as intermittent failures all relating
to an `AssertionError` on the return value of this block, which
seems to have a relevant value when `OSError` is thrown. Removing
this will not fix the problem but will at least let us see the
true cause of the failure for debugging and stabilization.

Differential Revision: https://phabricator.services.mozilla.com/D11884

--HG--
extra : moz-landing-system : lando
  • Loading branch information
cgsheeh committed Nov 14, 2018
1 parent 65cec28 commit 1e60366
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions python/mach/mach/test/test_telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ def run(*args, **kwargs):
**kwargs)
# Load any telemetry data that was written
path = unicode(tmpdir.join('telemetry', 'outgoing'))
try:
return [json.load(open(os.path.join(path, f), 'rb')) for f in os.listdir(path)]
except OSError:
return []
return [json.load(open(os.path.join(path, f), 'rb')) for f in os.listdir(path)]
return run


Expand Down

0 comments on commit 1e60366

Please sign in to comment.