Skip to content

Commit

Permalink
Bug 1851323 - Apply the latest line break rules. r=TYLin
Browse files Browse the repository at this point in the history
Since some issues such as bug 1851323 are fixed by ICU4X 1.3's data rule file,
I would like to apply it to get feedback in Gecko.

Differential Revision: https://phabricator.services.mozilla.com/D187980
  • Loading branch information
makotokato committed Sep 13, 2023
1 parent 3432a23 commit 1e6318b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion intl/icu_testdata/data/baked/segmenter/line_v1/und.rs.data

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions intl/update-icu4x.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ log "Change the directory to the cloned repo"
log ${tmpclonedir}
cd ${tmpclonedir}

log "Patching line segmenter data to fix https://github.com/unicode-org/icu4x/issues/3811."
# This manually patch can be removed once we upgrade to ICU4X 1.3 in bug 1851323.
wget --unlink -q -O ${tmpclonedir}/provider/datagen/data/segmenter/line.toml https://raw.githubusercontent.com/unicode-org/icu4x/fd62de5e232ea1f0cb81e88dc6eb0cf9c86f85ca/provider/datagen/src/transform/segmenter/rules/line.toml

log "Run the icu4x-datagen tool to regenerate the data."
log "Saving the data into: ${data_dir}"

Expand Down
12 changes: 6 additions & 6 deletions layout/reftests/css-grid/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ fuzzy-if(winWidget,0-1,0-5) == grid-fragmentation-017.html grid-fragmentation-01
== grid-fragmentation-018.html grid-fragmentation-018-ref.html
== grid-fragmentation-019.html grid-fragmentation-019-ref.html
== grid-fragmentation-020.html grid-fragmentation-020-ref.html
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
== grid-fragmentation-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-022.html grid-fragmentation-007-ref.html
== grid-fragmentation-023.html grid-fragmentation-023-ref.html
fuzzy-if(winWidget,0-1,0-5) == grid-fragmentation-024.html grid-fragmentation-024-ref.html
Expand Down Expand Up @@ -240,11 +240,11 @@ fuzzy-if(winWidget,0-1,0-5) == grid-fragmentation-027.html grid-fragmentation-02
== grid-fragmentation-dyn5-019.html grid-fragmentation-019-ref.html
== grid-fragmentation-dyn1-020.html grid-fragmentation-020-ref.html
== grid-fragmentation-dyn2-020.html grid-fragmentation-020-ref.html
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-dyn1-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-dyn2-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-dyn3-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-dyn4-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
pref(intl.icu4x.segmenter.enabled,false) == grid-fragmentation-dyn5-021.html grid-fragmentation-021-ref.html # https://github.com/unicode-org/icu4x/pull/3548
== grid-fragmentation-dyn1-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-dyn2-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-dyn3-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-dyn4-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-dyn5-021.html grid-fragmentation-021-ref.html
== grid-fragmentation-dyn2-022.html grid-fragmentation-007-ref.html
== grid-fragmentation-dyn1-023.html grid-fragmentation-023-ref.html
== grid-fragmentation-dyn2-023.html grid-fragmentation-023-ref.html
Expand Down

0 comments on commit 1e6318b

Please sign in to comment.