Skip to content

Commit

Permalink
Bug 1078033 - Remove remaining Camino code. r=ted
Browse files Browse the repository at this point in the history
  • Loading branch information
Archaeopteryx committed Oct 10, 2014
1 parent 63ccf00 commit 1e915ce
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 37 deletions.
6 changes: 0 additions & 6 deletions build/automation-build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ else
AUTOMATION_PPARGS += -DIS_LINUX=0
endif

ifeq ($(MOZ_BUILD_APP),camino)
AUTOMATION_PPARGS += -DIS_CAMINO=1
else
AUTOMATION_PPARGS += -DIS_CAMINO=0
endif

ifeq ($(host_os), cygwin)
AUTOMATION_PPARGS += -DIS_CYGWIN=1
endif
Expand Down
9 changes: 2 additions & 7 deletions build/automation.py.in
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ _APP_STATUS_CERTIFIED = 3
#else
_IS_CYGWIN = False
#endif
#expand _IS_CAMINO = __IS_CAMINO__ != 0
#expand _BIN_SUFFIX = __BIN_SUFFIX__

#expand _DEFAULT_APP = "./" + __BROWSER_PATH__
Expand Down Expand Up @@ -140,7 +139,6 @@ class Automation(object):
IS_MAC = _IS_MAC
IS_LINUX = _IS_LINUX
IS_CYGWIN = _IS_CYGWIN
IS_CAMINO = _IS_CAMINO
BIN_SUFFIX = _BIN_SUFFIX

UNIXISH = not IS_WIN32 and not IS_MAC
Expand Down Expand Up @@ -750,7 +748,7 @@ class Automation(object):
""" build the application command line """

cmd = os.path.abspath(app)
if self.IS_MAC and not self.IS_CAMINO and os.path.exists(cmd + "-bin"):
if self.IS_MAC and os.path.exists(cmd + "-bin"):
# Prefer 'app-bin' in case 'app' is a shell script.
# We can remove this hack once bug 673899 etc are fixed.
cmd += "-bin"
Expand All @@ -772,10 +770,7 @@ class Automation(object):

args.extend(("-no-remote", "-profile", profileDirectory))
if testURL is not None:
if self.IS_CAMINO:
args.extend(("-url", testURL))
else:
args.append((testURL))
args.append((testURL))
args.extend(extraArgs)
return cmd, args

Expand Down
4 changes: 0 additions & 4 deletions build/binary-location.mk
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@ endif

TARGET_DIST = $(TARGET_DEPTH)/dist

ifeq ($(MOZ_BUILD_APP),camino)
browser_path = $(TARGET_DIST)/Camino.app/Contents/MacOS/Camino
else
ifeq ($(OS_ARCH),Darwin)
browser_path = $(TARGET_DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/MacOS/$(program)
else
browser_path = $(TARGET_DIST)/bin/$(program)
endif
endif
7 changes: 1 addition & 6 deletions layout/forms/nsComboboxControlFrame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1596,12 +1596,7 @@ nsComboboxControlFrame::RestoreState(nsPresState* aState)
}


//
// Camino uses a native widget for the combobox
// popup, which affects drawing and event
// handling here and in nsListControlFrame.
//
// Also, Fennec use a custom combobox built-in widget
// Fennec uses a custom combobox built-in widget.
//

/* static */
Expand Down
2 changes: 0 additions & 2 deletions testing/profiles/prefs_general.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ user_pref("geo.wifi.timeToWaitBeforeSending", 2000);
user_pref("geo.wifi.scan", false);
user_pref("geo.wifi.logging.enabled", true);

user_pref("camino.warn_when_closing", false); // Camino-only, harmless to others

// Make url-classifier updates so rare that they won't affect tests
user_pref("urlclassifier.updateinterval", 172800);
// Point the url-classifier to the local testing server for fast failures
Expand Down
17 changes: 8 additions & 9 deletions widget/cocoa/nsAppShell.mm
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ - (void)beginMenuTracking:(NSNotification*)aNotification;
, mNativeEventScheduledDepth(0)
{
// A Cocoa event loop is running here if (and only if) we've been embedded
// by a Cocoa app (like Camino).
// by a Cocoa app.
mRunningCocoaEmbedded = [NSApp isRunning] ? true : false;
}

Expand Down Expand Up @@ -232,8 +232,8 @@ - (void)beginMenuTracking:(NSNotification*)aNotification;
{
NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;

// No event loop is running yet (unless Camino is running, or another
// embedding app that uses NSApplicationMain()).
// No event loop is running yet (unless an embedding app that uses
// NSApplicationMain() is running).
NSAutoreleasePool* localPool = [[NSAutoreleasePool alloc] init];

// mAutoreleasePools is used as a stack of NSAutoreleasePool objects created
Expand All @@ -258,9 +258,8 @@ - (void)beginMenuTracking:(NSNotification*)aNotification;
// This call initializes NSApplication unless:
// 1) we're using xre -- NSApp's already been initialized by
// MacApplicationDelegate.mm's EnsureUseCocoaDockAPI().
// 2) Camino is running (or another embedding app that uses
// NSApplicationMain()) -- NSApp's already been initialized and
// its main run loop is already running.
// 2) an embedding app that uses NSApplicationMain() is running -- NSApp's
// already been initialized and its main run loop is already running.
[NSBundle loadNibFile:
[NSString stringWithUTF8String:(const char*)nibPath.get()]
externalNameTable:
Expand Down Expand Up @@ -297,7 +296,7 @@ - (void)beginMenuTracking:(NSNotification*)aNotification;

if (!gAppShellMethodsSwizzled) {
// We should only replace the original terminate: method if we're not
// running in a Cocoa embedder (like Camino). See bug 604901.
// running in a Cocoa embedder. See bug 604901.
if (!mRunningCocoaEmbedded) {
nsToolkit::SwizzleMethods([NSApplication class], @selector(terminate:),
@selector(nsAppShell_NSApplication_terminate:));
Expand Down Expand Up @@ -618,8 +617,8 @@ - (void)beginMenuTracking:(NSNotification*)aNotification;
// to be processed elsewhere (in NativeEventCallback(), called from
// ProcessGeckoEvents()).
//
// Camino calls [NSApp run] on its own (via NSApplicationMain()), and so
// doesn't call nsAppShell::Run().
// Camino called [NSApp run] on its own (via NSApplicationMain()), and so
// didn't call nsAppShell::Run().
//
// public
NS_IMETHODIMP
Expand Down
2 changes: 1 addition & 1 deletion widget/cocoa/nsCocoaWindow.mm
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ static void FitRectToVisibleAreaForScreen(nsIntRect &aRect, NSScreen *aScreen,
}
}

// Some applications like Camino use native popup windows
// Some applications use native popup windows
// (native context menus, native tooltips)
static bool UseNativePopupWindows()
{
Expand Down
2 changes: 1 addition & 1 deletion widget/cocoa/nsToolkit.mm
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ static CGEventRef EventTapCallback(CGEventTapProxy proxy, CGEventType type, CGEv
if (getenv("MOZ_DEBUG"))
return;

// Don't do this for apps that (like Camino) use native context menus.
// Don't do this for apps that use native context menus.
#ifdef MOZ_USE_NATIVE_POPUP_WINDOWS
return;
#endif /* MOZ_USE_NATIVE_POPUP_WINDOWS */
Expand Down
2 changes: 1 addition & 1 deletion widget/cocoa/nsWindowMap.mm
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ - (void)dealloc
// As best I can tell, if the notification's object has a corresponding
// top-level widget (an nsCocoaWindow object), it has a delegate (set in
// nsCocoaWindow::StandardCreate()) of class WindowDelegate, and otherwise
// not (Camino doesn't use top-level widgets (nsCocoaWindow objects) --
// not (Camino didn't use top-level widgets (nsCocoaWindow objects) --
// only child widgets (nsChildView objects)). (The notification is sent
// to windowBecameKey: or windowBecameMain: below.)
//
Expand Down

0 comments on commit 1e915ce

Please sign in to comment.