Bug 1320607 - [devtools] Remove the generated CSS Properties database…

…. r=devtools-reviewers,nchevobbe

This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.

Differential Revision: https://phabricator.services.mozilla.com/D187492

.eslintignore

@@ -78,7 +78,6 @@ devtools/client/debugger/webpack.config.js
 devtools/client/preferences/
 
 # Ignore devtools generated code
-devtools/shared/css/generated/properties-db.js
 devtools/client/webconsole/test/node/fixtures/stubs/*.js
 !devtools/client/webconsole/test/node/fixtures/stubs/index.js
 devtools/client/shared/components/test/node/stubs/reps/*.js

.prettierignore

@@ -1054,7 +1054,6 @@ devtools/client/debugger/webpack.config.js
 devtools/client/preferences/
 
 # Ignore devtools generated code
-devtools/shared/css/generated/properties-db.js
 devtools/client/webconsole/test/node/fixtures/stubs/*.js
 !devtools/client/webconsole/test/node/fixtures/stubs/index.js
 devtools/client/shared/components/test/node/stubs/reps/*.js

devtools/client/fronts/css-properties.js

@@ -18,12 +18,6 @@ loader.lazyRequireGetter(
   "resource://devtools/shared/css/color-db.js",
   true
 );
-loader.lazyRequireGetter(
-  this,
-  "CSS_PROPERTIES_DB",
-  "resource://devtools/shared/css/properties-db.js",
-  true
-);
 loader.lazyRequireGetter(
   this,
   "CSS_TYPES",
@@ -181,16 +175,6 @@ function isCssVariable(input) {
   return !!input.match(IS_VARIABLE_TOKEN);
 }
 
-/**
- * Get a client-side CssProperties. This is useful for dependencies in tests, or parts
- * of the codebase that don't particularly need to match every known CSS property on
- * the target.
- * @return {CssProperties}
- */
-function getClientCssProperties() {
-  return new CssProperties(normalizeCssData(CSS_PROPERTIES_DB));
-}
-
 /**
  * Even if the target has the cssProperties actor, the returned data may not be in the
  * same shape or have all of the data we need. This normalizes the data and fills in
@@ -200,49 +184,9 @@ function getClientCssProperties() {
  */
 function normalizeCssData(db) {
   // If there is a `from` attributes, it means that it comes from RDP
-  // and it is not the client CSS_PROPERTIES_DB object.
-  // (prevent comparing to CSS_PROPERTIES_DB to avoid loading client database)
+  // and it is not the client `generateCssProperties()` object passed by tests.
   if (typeof db.from == "string") {
-    const missingSupports = !db.properties.color.supports;
-    const missingValues = !db.properties.color.values;
-    const missingSubproperties = !db.properties.background.subproperties;
-    const missingIsInherited = !db.properties.font.isInherited;
-
-    const missingSomething =
-      missingSupports ||
-      missingValues ||
-      missingSubproperties ||
-      missingIsInherited;
-
-    if (missingSomething) {
-      for (const name in db.properties) {
-        // Skip the current property if we can't find it in CSS_PROPERTIES_DB.
-        if (typeof CSS_PROPERTIES_DB.properties[name] !== "object") {
-          continue;
-        }
-
-        // Add "supports" information to the css properties if it's missing.
-        if (missingSupports) {
-          db.properties[name].supports =
-            CSS_PROPERTIES_DB.properties[name].supports;
-        }
-        // Add "values" information to the css properties if it's missing.
-        if (missingValues) {
-          db.properties[name].values =
-            CSS_PROPERTIES_DB.properties[name].values;
-        }
-        // Add "subproperties" information to the css properties if it's missing.
-        if (missingSubproperties) {
-          db.properties[name].subproperties =
-            CSS_PROPERTIES_DB.properties[name].subproperties;
-        }
-        // Add "isInherited" information to the css properties if it's missing.
-        if (missingIsInherited) {
-          db.properties[name].isInherited =
-            CSS_PROPERTIES_DB.properties[name].isInherited;
-        }
-      }
-    }
+    // This is where to put backward compat tweaks here to support old runtimes.
   }
 
   reattachCssColorValues(db);
@@ -271,7 +215,8 @@ function reattachCssColorValues(db) {
 
 module.exports = {
   CssPropertiesFront,
-  getClientCssProperties,
   isCssVariable,
+  CssProperties,
+  normalizeCssData,
 };
 registerFront(CssPropertiesFront);

devtools/client/inspector/shared/test/browser_styleinspector_output-parser.js

@@ -9,9 +9,6 @@
 // tested with an xpcshell test as the output-parser requires the DOM to work.
 
 const OutputParser = require("resource://devtools/client/shared/output-parser.js");
-const {
-  getClientCssProperties,
-} = require("resource://devtools/client/fronts/css-properties.js");
 
 const COLOR_CLASS = "color-class";
 const URL_CLASS = "url-class";

devtools/client/shared/sourceeditor/css-autocompleter.js

@@ -8,9 +8,6 @@ const {
   cssTokenizer,
   cssTokenizerWithLineColumn,
 } = require("resource://devtools/shared/css/parsing-utils.js");
-const {
-  getClientCssProperties,
-} = require("resource://devtools/client/fronts/css-properties.js");
 
 /**
  * Here is what this file (+ css-parsing-utils.js) do.
@@ -89,8 +86,7 @@ const SELECTOR_STATES = {
 function CSSCompleter(options = {}) {
   this.walker = options.walker;
   this.maxEntries = options.maxEntries || 15;
-  // If no css properties database is passed in, default to the client list.
-  this.cssProperties = options.cssProperties || getClientCssProperties();
+  this.cssProperties = options.cssProperties;
 
   this.propertyNames = this.cssProperties.getNames().sort();
 

devtools/client/shared/sourceeditor/test/browser_css_autocompletion.js

@@ -93,9 +93,10 @@ async function runTests() {
   const target = await createAndAttachTargetForTab(gBrowser.selectedTab);
   inspector = await target.getFront("inspector");
   const walker = inspector.walker;
+  const cssPropertiesFront = await target.getFront("cssProperties");
   completer = new CSSCompleter({
     walker,
-    cssProperties: getClientCssProperties(),
+    cssProperties: cssPropertiesFront.cssProperties,
   });
   await checkStateAndMoveOn();
   await completer.walker.release();

devtools/client/shared/sourceeditor/test/browser_editor_autocomplete_events.js

@@ -16,12 +16,13 @@ async function runTests() {
   const target = await createAndAttachTargetForTab(gBrowser.selectedTab);
   const inspector = await target.getFront("inspector");
   const walker = inspector.walker;
+  const cssPropertiesFront = await target.getFront("cssProperties");
   const { ed, win, edWin } = await setup({
     autocomplete: true,
     mode: Editor.modes.css,
     autocompleteOpts: {
       walker,
-      cssProperties: getClientCssProperties(),
+      cssProperties: cssPropertiesFront.cssProperties,
     },
   });
   await testMouse(ed, edWin);

devtools/client/shared/sourceeditor/test/head.js

@@ -13,9 +13,6 @@ Services.scriptloader.loadSubScript(
 );
 
 const Editor = require("resource://devtools/client/shared/sourceeditor/editor.js");
-const {
-  getClientCssProperties,
-} = require("resource://devtools/client/fronts/css-properties.js");
 
 function promiseWaitForFocus(el) {
   return new Promise(resolve => waitForFocus(resolve, el));

devtools/client/shared/test/browser_outputparser.js

@@ -3,10 +3,6 @@
 
 "use strict";
 
-const {
-  getClientCssProperties,
-} = require("resource://devtools/client/fronts/css-properties.js");
-
 add_task(async function () {
   await pushPref("layout.css.backdrop-filter.enabled", true);
   await pushPref("layout.css.individual-transform.enabled", true);

devtools/client/shared/test/shared-head.js

@@ -2207,3 +2207,24 @@ function logCssCompatDataPropertiesWithoutMDNUrl() {
   }
   walk(cssPropertiesCompatData);
 }
+
+/**
+ * Craft a CssProperties instance without involving RDP for tests
+ * manually spawning OutputParser, CssCompleter, Editor...
+ *
+ * Otherwise this should instead be fetched from CssPropertiesFront.
+ *
+ * @return {CssProperties}
+ */
+function getClientCssProperties() {
+  const {
+    generateCssProperties,
+  } = require("resource://devtools/server/actors/css-properties.js");
+  const {
+    CssProperties,
+    normalizeCssData,
+  } = require("resource://devtools/client/fronts/css-properties.js");
+  return new CssProperties(
+    normalizeCssData({ properties: generateCssProperties() })
+  );
+}