Skip to content

Commit

Permalink
Bug 1799460 - Use width rather than min-width to set right/left menu …
Browse files Browse the repository at this point in the history
…sizes on windows menus. r=Gijs

This was hitting an interesting difference between XUL and non-XUL layout, when
you set min-width: <something> to something that also has non-default
appearance and imposes a min size.

This should behave consistently in both layout modes.

Differential Revision: https://phabricator.services.mozilla.com/D161499
  • Loading branch information
emilio committed Nov 16, 2022
1 parent a8a5c8f commit 32c2b25
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions toolkit/themes/windows/global/menu.css
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ menubar > menu:-moz-window-inactive {
}

.menu-iconic-left {
min-width: 1.45em;
width: 1.45em;
}

.menu-iconic-icon {
Expand Down Expand Up @@ -136,7 +136,7 @@ menubar > menu:-moz-window-inactive {
-moz-default-appearance: menuarrow;
margin-inline-end: -2px;
list-style-image: none;
min-width: 1.28em;
width: 1.28em;
padding-top: 1px;
}

Expand Down Expand Up @@ -329,7 +329,7 @@ menuitem:is([type="checkbox"], [checked="true"], [type="radio"]) > .menu-iconic-
menuitem[type="checkbox"],
menuitem[type="radio"] {
appearance: none !important; /* to override more specific selectors above. */
min-width: unset;
width: unset;
}

.menu-iconic > .menu-iconic-left,
Expand Down

0 comments on commit 32c2b25

Please sign in to comment.