Bug 1796073 - [remote] Make columnNumber in exceptions and stackTrace…

…s 0-based. r=webdriver-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D162280
dothq · Nov 17, 2022 · 365c5b2 · 365c5b2
1 parent 66dbc65
commit 365c5b2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/remote/webdriver-bidi/modules/windowglobal/log.sys.mjs b/remote/webdriver-bidi/modules/windowglobal/log.sys.mjs
@@ -71,9 +71,8 @@ class LogModule extends Module {
       .filter(frame => !lazy.isChromeFrame(frame))
       .map(frame => {
         return {
-          columnNumber: frame.columnNumber,
+          columnNumber: frame.columnNumber - 1,
           functionName: frame.functionName,
-          // Match WebDriver BiDi and convert Firefox's one-based line number.
           lineNumber: frame.lineNumber - 1,
           url: frame.filename,
         };

diff --git a/remote/webdriver-bidi/modules/windowglobal/script.sys.mjs b/remote/webdriver-bidi/modules/windowglobal/script.sys.mjs
@@ -64,15 +64,15 @@ class ScriptModule extends Module {
       // WebDriver BiDi.
       .map(frame => {
         return {
-          columnNumber: frame.columnNumber,
+          columnNumber: frame.columnNumber - 1,
           functionName: frame.functionName,
           lineNumber: frame.lineNumber - 1,
           url: frame.filename,
         };
       });
 
     return {
-      columnNumber: stack.column,
+      columnNumber: stack.column - 1,
       exception: lazy.serialize(
         exception,
         1,

diff --git a/testing/web-platform/meta/webdriver/tests/bidi/log/entry_added/stacktrace.py.ini b/testing/web-platform/meta/webdriver/tests/bidi/log/entry_added/stacktrace.py.ini
@@ -2,15 +2,3 @@
   [test_console_entry_sync_callstack[warn-True\]]
     bug: 1744705
     expected: FAIL
-
-  [test_console_entry_sync_callstack[assert-True\]]
-    expected: FAIL
-
-  [test_console_entry_sync_callstack[error-True\]]
-    expected: FAIL
-
-  [test_console_entry_sync_callstack[trace-True\]]
-    expected: FAIL
-
-  [test_javascript_entry_sync_callstack]
-    expected: FAIL