Skip to content

Commit

Permalink
Bug 1304508 - Remove makefile mkdir testing; r=ted
Browse files Browse the repository at this point in the history
Several years ago, joey starting writing a handful of unit tests for
primitives in our make files. IIRC a lot of the impetus behind this
work was to flush out bugs between GNU make and pymake.

AFAICT the only survivor of these tests today is check_mkdir.py. The
test is a one-off and has been a bit fragile over the years,
contributing technical debt along the way. And as part of removing the
last references to pymake in automation, it is once again showing
itself and failing in a way that has to do with the way the test
is written and not an issue with the code it is testing. Enough is
enough. This commit removes the test and eliminates the technical
debt. I don't think it will be missed.

MozReview-Commit-ID: 3OzurtFbcyD

--HG--
extra : rebase_source : 6d3cf6121c90e9c47948862b8c4117bb1d3e5afd
  • Loading branch information
indygreg committed Apr 26, 2017
1 parent 64ce8ef commit 3712aec
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 335 deletions.
270 changes: 0 additions & 270 deletions config/tests/makefiles/autodeps/check_mkdir.py

This file was deleted.

64 changes: 0 additions & 64 deletions config/tests/makefiles/autodeps/testor.tmpl

This file was deleted.

1 change: 0 additions & 1 deletion config/tests/python.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@
[unit-mozunit.py]
[unit-nsinstall.py]
[unit-printprereleasesuffix.py]
[makefiles/autodeps/check_mkdir.py]

0 comments on commit 3712aec

Please sign in to comment.