Skip to content

Commit

Permalink
Bug 1738684 - Avoid the warnings collector from eating build output. …
Browse files Browse the repository at this point in the history
…r=firefox-build-system-reviewers,ahochheiden

If for some reason the warning collector throws an exception, we ignore
it, which is fine, but we also end up not setting the message for the
BuildOutputResult, which means the line is not displayed.

It's better for the warning collector to miss a warning than for the
output to pretend the line wasn't there to begin with.

Differential Revision: https://phabricator.services.mozilla.com/D192046
  • Loading branch information
glandium committed Oct 27, 2023
1 parent 3daffd4 commit 3738566
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/mozbuild/mozbuild/controller/building.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,10 +355,10 @@ def on_line(self, line):
return BuildOutputResult(None, False, None)

warning = None
message = line

try:
warning = self._warnings_collector.process_line(line)
message = line
except Exception:
pass

Expand Down

0 comments on commit 3738566

Please sign in to comment.